public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@transmeta.com>
To: DJ Delorie <dj@delorie.com>
Cc: amacleod@redhat.com, amodra@bigpond.net.au,
	binutils@sources.redhat.com, cgen@sources.redhat.com
Subject: Re: New Sanyo Stormy16 relocations
Date: Tue, 17 Dec 2002 11:25:00 -0000	[thread overview]
Message-ID: <15871.31192.305439.813418@casey.transmeta.com> (raw)
In-Reply-To: <200212170353.gBH3r9f14238@envy.delorie.com>

DJ Delorie writes:
 > I'm committing this approved patch on Andrew's behalf.  The cgen parts
 > were approved by FChE off-list.
 > 
 > > bfd/ChangeLog
 > > 	* elf32-xstormy16.c (xstormy16_elf_howto): Add R_XSTORMY16_LO16
 > > 	and R_XSTORMY16_HI16) howto entries.
 > > 	(xstormy16_reloc_map): Map R_XSTORMY16_{LO,HI}16 to BFD_RELOC_{LO,HI}16.
 > > 	(xstormy16_info_to_howto_rela): Use R_XSTORMY16_GNU_VTINHERIT to 
 > > 	determine the start of the second reloc table.
 > > 
 > > cgen/ChangeLog
 > > 	* cpu/xstormy16.cpu (imm16): Call handler immediate16.
 > > 	* cpu/xstormy16.opc (parse_small_immediate): Return on '@'.
 > > 	(parse_immediate16): Handle immediate16 values, which now include
 > > 	@hi(label) and @lo(label)
 > > 
 > > gas/ChangeLog
 > > 	* config/tc-xstormy16.c (md_cgen_lookup_reloc): If a relocation 
 > > 	has already been set up, use it.
 > > 
 > > include/ChangeLog
 > > 	* elf/xstormy16.h (START_RELOC_NUMBERS) Add relocation numbers
 > > 	for R_XSTORMY16_LO16 and R_XSTORMY16_HI16.
 > > 
 > > opcodes/ChangeLog
 > > 	* opcodes/xstormy16-asm.c: Regenerate.

Having to get cgen approval for cpu-specific changes sucks.
People should be able to police their own ports.
gcc port maintainers don't have to get approval for changes to their
ports.  I don't understand why this would be any different.

Is there a reason for this (anal-retentive) procedure?
[I'm not suggesting you or anyone else is actually imposing this of course.
Maybe people just think that's the way things are.]

But, if approval is required, methinks binutils is a better place to
provide approval for .opc changes (e.g. complaints about warnings :-).

  parent reply	other threads:[~2002-12-17 19:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1039041358.28757.307.camel@p4>
     [not found] ` <20021204225643.GS27956@bubble.sa.bigpond.net.au>
     [not found]   ` <1039043233.28767.313.camel@p4>
2002-12-16 19:53     ` DJ Delorie
2002-12-16 20:30       ` Alan Modra
2002-12-16 20:48         ` DJ Delorie
2002-12-17 11:25       ` Doug Evans [this message]
2002-12-17 11:47         ` DJ Delorie
2002-12-17 11:56           ` Frank Ch. Eigler
2002-12-17 12:09           ` Doug Evans
2002-12-17 12:14             ` Doug Evans
2002-12-18  2:37           ` Andrew Cagney
2002-12-18  7:47             ` Frank Ch. Eigler
2002-12-17 14:39         ` Ben Elliston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15871.31192.305439.813418@casey.transmeta.com \
    --to=dje@transmeta.com \
    --cc=amacleod@redhat.com \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=cgen@sources.redhat.com \
    --cc=dj@delorie.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).