From: Doug Evans <dje@transmeta.com>
To: DJ Delorie <dj@delorie.com>
Cc: binutils@sources.redhat.com, cgen@sources.redhat.com,
sid@sources.redhat.com, gdb@sources.redhat.com
Subject: Re: New Sanyo Stormy16 relocations
Date: Tue, 17 Dec 2002 12:09:00 -0000 [thread overview]
Message-ID: <15871.33865.254007.550012@casey.transmeta.com> (raw)
In-Reply-To: <200212171947.gBHJl3P23665@envy.delorie.com>
DJ Delorie writes:
> > Having to get cgen approval for cpu-specific changes sucks.
> > People should be able to police their own ports.
> > gcc port maintainers don't have to get approval for changes to their
> > ports. I don't understand why this would be any different.
>
> Because cgen feeds binutils, gdb, and sid. Which one of those has the
> port maintainers responsible for cgen? What happens if a binutils
> maintainer changes cgen, and unknowingly breaks sid or gdb?
[Just to be clear, the context of my remarks is changes to .cpu/.opc files.
Nothing else.]
A port maintainer is a port maintainer.
If redhat is the port maintainer for xstormy16 and checks in something to
xstormy16.cpu because they need to change binutils and later find out
they've broken gdb(sim) it's a problem of their own doing. They can undo it.
Similarily for any port maintainer.
> > But, if approval is required, methinks binutils is a better place to
> > provide approval for .opc changes (e.g. complaints about warnings :-).
>
> Better than sid? Better than gdb?
I don't understand. The context here is .opc. files.
Changes to .opc files don't affect sid or gdb. Only binutils.
> OTOH we've talked about moving the
> port-specific files out of cgen and into their own toplevel directory,
> which would remove this issue anyway.
>
> But, let me make the formal request anyway. gdb and sid cc'd.
>
> Cgen folks (and others)... would it be acceptable to change the cgen
> approval rules to allow people who could otherwise approve
> port-specific patches in binutils, gdb, or sid, to be allowed to
> approve port-specific changes in cgen as well?
I'm not sure I would word it that way. Maybe it's ok, I dunno.
uber-hackers in binutils/gdb may be able to make port specific
changes as they deem necessary (are they?). I'm not sure this should extend
to .cpu files. But I certainly have no problem with authorized
port maintainers of binutils/gdb making changes to cgen port-specific
files (provided of course they're willing to work through any problems
that may arise).
Given the above seemingly misunderstandings, just so we're clear,
"port-specific changes" means changes to files in src/cgen/cpu
[or whereever they move to].
next prev parent reply other threads:[~2002-12-17 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1039041358.28757.307.camel@p4>
[not found] ` <20021204225643.GS27956@bubble.sa.bigpond.net.au>
[not found] ` <1039043233.28767.313.camel@p4>
2002-12-16 19:53 ` DJ Delorie
2002-12-16 20:30 ` Alan Modra
2002-12-16 20:48 ` DJ Delorie
2002-12-17 11:25 ` Doug Evans
2002-12-17 11:47 ` DJ Delorie
2002-12-17 11:56 ` Frank Ch. Eigler
2002-12-17 12:09 ` Doug Evans [this message]
2002-12-17 12:14 ` Doug Evans
2002-12-18 2:37 ` Andrew Cagney
2002-12-18 7:47 ` Frank Ch. Eigler
2002-12-17 14:39 ` Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15871.33865.254007.550012@casey.transmeta.com \
--to=dje@transmeta.com \
--cc=binutils@sources.redhat.com \
--cc=cgen@sources.redhat.com \
--cc=dj@delorie.com \
--cc=gdb@sources.redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).