public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Doug Evans <dje@transmeta.com>
Cc: binutils@sources.redhat.com, cgen@sources.redhat.com
Subject: Re: include/dis-asm.h patch for cgen disassemblers
Date: Thu, 31 Jan 2002 13:21:00 -0000	[thread overview]
Message-ID: <20020131162132.I19966@redhat.com> (raw)
In-Reply-To: <15449.42904.232177.265525@casey.transmeta.com>; from dje@transmeta.com on Thu, Jan 31, 2002 at 12:22:48PM -0800

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

Hi -


dje wrote:
> [...]
> Blech.
> [...]
> I'd go with the first possibility, and not overload `mach'.
> Instead of arch/mach in disassemble_info, have arch/mach/mumble
> [...]

OK.  How about this?  It is simpler, but it furthers
disassemble_info field sprawl.


- FChE


Index: opcodes/ChangeLog
===================================================================
@@ -1,3 +1,7 @@
+2002-01-31  Frank Ch. Eigler  <fche@redhat.com>
+
+	* cgen-dis.in (print_insn_@arch@): Support disassemble_info.isas.
+

Index: opcodes/cgen-dis.in
===================================================================
@@ -386,7 +386,7 @@ print_insn_@arch@ (pc, info)
 #ifdef CGEN_COMPUTE_ISA
   isa = CGEN_COMPUTE_ISA (info);
 #else
-  isa = 0;
+  isa = info->isas;
 #endif
 
   /* If we've switched cpu's, close the current table and open a new one.  */

Index: include/ChangeLog
===================================================================
@@ -1,3 +1,8 @@
+2002-01-31  Frank Ch. Eigler  <fche@redhat.com>
+
+	* dis-asm.h (isas): New field in disassemble_info.
+	(INIT_DISASSEMBLE_INFO): Clear it.
+
Index: include/dis-asm.h
===================================================================
@@ -73,6 +73,8 @@ typedef struct disassemble_info {
   unsigned long mach;
   /* Endianness (for bi-endian cpus).  Mono-endian cpus can ignore this.  */
   enum bfd_endian endian;
+  /* A target-specific indication of applicable instruction sets.  */
+  unsigned long isas;
 
   /* Some targets need information about the current section to accurately
      display insns.  If this is NULL, the target disassembler function
@@ -271,6 +273,7 @@ extern int generic_symbol_at_address
   (INFO).flavour = bfd_target_unknown_flavour, \
   (INFO).arch = bfd_arch_unknown, \
   (INFO).mach = 0, \
+  (INFO).isas = 0, \
   (INFO).endian = BFD_ENDIAN_UNKNOWN, \
   (INFO).octets_per_byte = 1, \
   INIT_DISASSEMBLE_INFO_NO_ARCH(INFO, STREAM, FPRINTF_FUNC)


[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

  reply	other threads:[~2002-01-31 21:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-31  9:43 Frank Ch. Eigler
2002-01-31 12:22 ` Doug Evans
2002-01-31 13:21   ` Frank Ch. Eigler [this message]
2002-01-31 13:41     ` Doug Evans
2002-02-01 10:13       ` Frank Ch. Eigler
2002-02-01 10:22         ` Doug Evans
2002-02-01 10:28         ` Andrew Cagney
2002-02-01 10:36           ` Frank Ch. Eigler
2002-02-01 11:00             ` Andrew Cagney
2002-01-31 13:55     ` Andrew Cagney
2002-01-31 15:42       ` Frank Ch. Eigler
2002-01-31 16:03         ` Andrew Cagney
2002-01-31 16:57           ` Frank Ch. Eigler
2002-01-31 22:33             ` Andrew Cagney
     [not found]               ` <20020201092827.H6166@redhat.com>
     [not found]                 ` <3C5AE910.4090009@cygnus.com>
2002-02-01 11:56                   ` Frank Ch. Eigler
2002-02-01 12:02                     ` Andrew Cagney
2002-02-01 12:10                       ` Frank Ch. Eigler
2002-02-01 12:44                         ` Andrew Cagney
2002-02-01 12:56                           ` Andrew Cagney
2002-02-01 13:23                             ` Frank Ch. Eigler
     [not found]                               ` <3C5B1E19.8030405@cygnus.com>
2002-02-04  8:32                                 ` Frank Ch. Eigler
     [not found]                                   ` <3C601DB8.7080700@cygnus.com>
2002-02-05 11:29                                     ` Frank Ch. Eigler
2002-02-05 12:42                                       ` Doug Evans
     [not found]                     ` <3C5AF9D1.8070607@cygnus.com>
2002-02-01 12:39                       ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020131162132.I19966@redhat.com \
    --to=fche@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=cgen@sources.redhat.com \
    --cc=dje@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).