public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Dave Brolley <brolley@redhat.com>
To: cgen@sources.redhat.com
Subject: [patch][commit] Typo in utils-sim.scm Generating Decoder
Date: Tue, 09 May 2006 18:45:00 -0000	[thread overview]
Message-ID: <4460E33D.1090806@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

Hi,

I've committed this patch which corrects a typo in the generation of the 
decoder. The generated code was intended to shift 'entire_insn' to the 
right when the insn length is less than the base insn size.

Tested on an internal port which exposed the problem.

Dave

[-- Attachment #2: cgen-decode.ChangeLog --]
[-- Type: text/plain, Size: 151 bytes --]

2006-05-09  Dave Brolley  <brolley@redhat.com>

	* utils-sim.scm (-gen-decode-insn-entry): Generated code should shift
	'entire_insn' not 'base_insn'.

[-- Attachment #3: cgen-decode.patch.txt --]
[-- Type: text/plain, Size: 1282 bytes --]

Index: cgen/utils-sim.scm
===================================================================
RCS file: /cvs/src/src/cgen/utils-sim.scm,v
retrieving revision 1.14
diff -c -p -r1.14 utils-sim.scm
*** cgen/utils-sim.scm	5 Dec 2005 01:27:23 -0000	1.14
--- cgen/utils-sim.scm	9 May 2006 18:39:16 -0000
***************
*** 1,5 ****
  ; Generic simulator application utilities.
! ; Copyright (C) 2000, 2005 Red Hat, Inc.
  ; This file is part of CGEN.
  ; See file COPYING.CGEN for details.
  
--- 1,5 ----
  ; Generic simulator application utilities.
! ; Copyright (C) 2000, 2005, 2006 Red Hat, Inc.
  ; This file is part of CGEN.
  ; See file COPYING.CGEN for details.
  
***************
*** 631,637 ****
  		     (if (and (equal? APPLICATION 'SID-SIMULATOR)
  			      (> (state-base-insn-bitsize) (insn-length insn)))
  			 (string-append
! 			  indent "    entire_insn = base_insn >> "
  			  (number->string (- (state-base-insn-bitsize) (insn-length insn)))
  			  ";\n")
  			 "")
--- 631,637 ----
  		     (if (and (equal? APPLICATION 'SID-SIMULATOR)
  			      (> (state-base-insn-bitsize) (insn-length insn)))
  			 (string-append
! 			  indent "    entire_insn = entire_insn >> "
  			  (number->string (- (state-base-insn-bitsize) (insn-length insn)))
  			  ";\n")
  			 "")

                 reply	other threads:[~2006-05-09 18:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4460E33D.1090806@redhat.com \
    --to=brolley@redhat.com \
    --cc=cgen@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).