From: Doug Evans <dje@sebabeach.org>
To: Masaki Muranaka <monaka@monami-software.com>
Cc: cgen@sourceware.org
Subject: Re: [PATCH] Log message fix
Date: Thu, 18 Jun 2009 15:35:00 -0000 [thread overview]
Message-ID: <4A3A5EB4.3070309@sebabeach.org> (raw)
In-Reply-To: <4E07CA97-7D2D-4084-A56A-A0299A5284F1@monami-software.com>
Masaki Muranaka wrote:
> Hello,
> Thanks for your comment.
> I re-generated the patch to get more consistency.
>
Yikes. I think I goofed in the sense that at least for the sims the
files don't have a "$cpu-" prefix.
E.g. In the gdb tree, ls src/sim/m32r.
Opcode files need the prefix because they all live in the same directory.
That's not the case with the sims.
Ummm, "Sorry about that Chief". :-(
I realize it's just a debugging printf, but OTOH "consistency is good".
How about something that works regardless of what the file is.
Maybe something like:
(logit 1 "Generating " (gen-cpu-name) "'s cpu.h ...\n")
Or some such ...
I can do that if you want. Saves you from having to retype everything
again.
Apologies.
next prev parent reply other threads:[~2009-06-18 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 20:06 Masaki Muranaka
2009-06-18 5:39 ` Doug Evans
2009-06-18 7:57 ` Masaki Muranaka
2009-06-18 15:35 ` Doug Evans [this message]
2009-07-07 0:19 ` Masaki Muranaka
2009-06-20 21:36 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A5EB4.3070309@sebabeach.org \
--to=dje@sebabeach.org \
--cc=cgen@sourceware.org \
--cc=monaka@monami-software.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).