public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Doug Evans <dje@sebabeach.org>
To: Masaki Muranaka <monaka@monami-software.com>
Cc: cgen@sourceware.org
Subject: Re: [PATCH] Log message fix
Date: Thu, 18 Jun 2009 05:39:00 -0000	[thread overview]
Message-ID: <4A39D323.6090406@sebabeach.org> (raw)
In-Reply-To: <842A757C-C343-4363-B406-8A14AA8CCBF5@monami-software.com>

Masaki Muranaka wrote:
> Hello,
>
> This is a small and obvious fix. Is ChangeLog entry needed?
>
> --
> Masaki Muranaka
> Monami software
>
>   

Hi.  Thanks for the patch.
It's actually a style issue whether to print this message the former way 
or the new way with your patch.
I realize cgen is inconsistent about this.  Darn.
E.g. For examples, grep "logit.*Generating" *.scm

I don't mind going with your patch, the output is clearer.

Technically speaking, all patches require a ChangeLog entry.
But I can write one for you for this one.  No worries.

  reply	other threads:[~2009-06-18  5:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 20:06 Masaki Muranaka
2009-06-18  5:39 ` Doug Evans [this message]
2009-06-18  7:57   ` Masaki Muranaka
2009-06-18 15:35     ` Doug Evans
2009-07-07  0:19       ` Masaki Muranaka
2009-06-20 21:36     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A39D323.6090406@sebabeach.org \
    --to=dje@sebabeach.org \
    --cc=cgen@sourceware.org \
    --cc=monaka@monami-software.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).