From: Paolo Bonzini <bonzini@gnu.org>
To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Cc: cgen@sourceware.org, gdb-patches@sourceware.org
Subject: Re: Fixup readline and sim including of override.m4
Date: Fri, 21 Aug 2009 06:37:00 -0000 [thread overview]
Message-ID: <4A8E40B3.70907@gnu.org> (raw)
In-Reply-To: <20090821054955.GB8004@gmx.de>
On 08/21/2009 07:49 AM, Ralf Wildenhues wrote:
> Applying the fopen fixup to override.m4 and rebuilding the autotools
> update patch set made it clear that override.m4 wasn't consistently
> included everywhere in binutils+gdb yet.
>
> I used m4_include instead of m4_sinclude so that we'd learn about
> failures to include. Unfortunately, m4 inclusion doesn't work the
> way C '#include "sub/file"' works (starting relative from the current
> file) so that a sinclude would silently fail if a configure.in file were
> added that wasn't in a direct subdir of sim (due to the then-wrong
> relative paths).
>
> OK to squash this additional change in (or just commit it before the
> patch set)?
Ok unless someone complains in 24 hours.
Paolo
prev parent reply other threads:[~2009-08-21 6:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 5:50 Ralf Wildenhues
2009-08-21 6:37 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A8E40B3.70907@gnu.org \
--to=bonzini@gnu.org \
--cc=Ralf.Wildenhues@gmx.de \
--cc=cgen@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).