From: Doug Evans <dje@sebabeach.org>
To: Dave Korn <dave.korn.cygwin@googlemail.com>
Cc: cgen@sourceware.org
Subject: Re: [patch] One more cpu-vs-prefix fix.
Date: Mon, 05 Oct 2009 18:04:00 -0000 [thread overview]
Message-ID: <4ACA3543.6000000@sebabeach.org> (raw)
In-Reply-To: <4AC18628.9060202@gmail.com>
Dave Korn wrote:
> Hiya! I found one more place that looks to me like it should be using
> @prefix@ instead of @cpu@, since that's how all the rest of the code generates
> the "XXX_init_idesc_table" name.
>
> I haven't tested this much yet except that it fixes a discrepancy between
> the prototype generated in the decode.h and the function call in the mloop.c
> files for the private port I'm working on. I think that sh64 is the only
> target where there actually is any difference between @prefix@ and @cpu@ in
> practice, so I tried regenerating it and it seemed to compile ok, or at any
> rate without any missing or duplicated symbols. I couldn't get the tests to
> run, they all fail with an error that suggests the testsuite is attempting to
> run target binaries on the host machine:
>
>
>> spawn /sgun/tools/obj.sh64/ld/ld-new andb.cgs.o -m shelf32 -o andb.cgs.x
>> andb.cgs.x
>> spawn andb.cgs.x
>> andb.cgs.x: andb.cgs.x: cannot execute binary file
>> FAIL: sh5 andb.cgs (execution)
>> Testing andi.cgs on machine sh5.
>>
>
> So whatever that is, I'd guess it's not related. Here's a changelog entry,
> if you want the patch:
>
> cgen/ChangeLog:
>
> * sim-model.scm (@cpu@_prepare_run): Use @prefix@, not @cpu@.
>
> cheers,
> DaveK
>
>
Thanks for the patch!
I checked it in.
prev parent reply other threads:[~2009-10-05 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 3:45 Dave Korn
2009-10-05 18:04 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACA3543.6000000@sebabeach.org \
--to=dje@sebabeach.org \
--cc=cgen@sourceware.org \
--cc=dave.korn.cygwin@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).