public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: cgen@sourceware.org
Subject: Re: [RFC 04/14] Remove =? and >=? aliases
Date: Sun, 20 Aug 2023 10:15:17 +0200	[thread overview]
Message-ID: <87v8daqgdm.fsf@gnu.org> (raw)
In-Reply-To: <20230819174900.866436-5-tom@tromey.com> (Tom Tromey's message of "Sat, 19 Aug 2023 11:42:03 -0600")


OK.  Thanks.

> =? and >=? are aliases for = and >=.  Remove these and update the few
> users.
> ---
>  enum.scm     | 2 +-
>  guile.scm    | 4 ----
>  opcodes.scm  | 4 ++--
>  sim-test.scm | 4 ++--
>  4 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/enum.scm b/enum.scm
> index 1faeb5f..5390e08 100644
> --- a/enum.scm
> +++ b/enum.scm
> @@ -278,7 +278,7 @@
>  				  "sanitize-"
>  				  san-code " */")
>  		   "")
> -	       (if (or san? (=? (remainder n 4) 0))
> +	       (if (or san? (= (remainder n 4) 0))
>  		   "\n "
>  		   "")
>  	       (if (= n 0)
> diff --git a/guile.scm b/guile.scm
> index d2b8d8d..85c37d4 100644
> --- a/guile.scm
> +++ b/guile.scm
> @@ -37,10 +37,6 @@
>        )
>  )
>  
> -; FIXME: to be deleted
> -(define =? =)
> -(define >=? >=)
> -
>  (if (not (symbol-bound? #f '%stat))
>      (begin
>        (define %stat stat)
> diff --git a/opcodes.scm b/opcodes.scm
> index 66ce9dd..1644fcd 100644
> --- a/opcodes.scm
> +++ b/opcodes.scm
> @@ -771,12 +771,12 @@
>  			   (begin
>  			     (close-port port)
>  			     ; End of file, did we find the text?
> -			     (if (=? start -1)
> +			     (if (= start -1)
>  				 ""
>  				 (substring result start index))))
>  			  ((char=? char #\newline)
>  			   ; Check for start delim or end delim?
> -			   (if (=? start -1)
> +			   (if (= start -1)
>  			       (if (string=? (substring result line
>  							(+ (string-length start-delim)
>  							   line))
> diff --git a/sim-test.scm b/sim-test.scm
> index 8176070..3029105 100644
> --- a/sim-test.scm
> +++ b/sim-test.scm
> @@ -106,8 +106,8 @@
>    (let ((test-data (map (lambda (op) (operand-test-data op n)) op-list))
>  	(len (length op-list)))
>      ; FIXME: Make slicker later.
> -    (cond ((=? len 0) (list (list)))
> -	  ((=? len 1) test-data)
> +    (cond ((= len 0) (list (list)))
> +	  ((= len 1) test-data)
>  	  (else (list (map car test-data)))))
>  )

  reply	other threads:[~2023-08-20  8:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19 17:41 [RFC 00/14] Port to Guile 3.0 Tom Tromey
2023-08-19 17:42 ` [RFC 01/14] Add a .gitignore Tom Tromey
2023-08-20  8:04   ` Jose E. Marchesi
2023-08-19 17:42 ` [RFC 02/14] Remove some 'fastcall' code Tom Tromey
2023-08-20  8:13   ` Jose E. Marchesi
2023-08-22 16:52     ` Tom Tromey
2023-08-19 17:42 ` [RFC 03/14] Remove bound-symbol? Tom Tromey
2023-08-20  8:14   ` Jose E. Marchesi
2023-08-19 17:42 ` [RFC 04/14] Remove =? and >=? aliases Tom Tromey
2023-08-20  8:15   ` Jose E. Marchesi [this message]
2023-08-19 17:42 ` [RFC 05/14] Fix bug in insn.scm Tom Tromey
2023-08-20  8:15   ` Jose E. Marchesi
2023-08-19 17:42 ` [RFC 06/14] Remove support for old versions of Guile Tom Tromey
2023-08-19 17:42 ` [RFC 07/14] Use define-macro in rtl.scm Tom Tromey
2023-08-19 17:42 ` [RFC 08/14] Remove let bindings of macros Tom Tromey
2023-08-20  8:33   ` Jose E. Marchesi
2023-08-19 17:42 ` [RFC 09/14] Remove define-in-define Tom Tromey
2023-08-19 17:42 ` [RFC 10/14] Hack cos.scm to work with new Guile Tom Tromey
2023-08-19 17:42 ` [RFC 11/14] Invalid code in rtx-traverse.scm Tom Tromey
2023-08-20  8:42   ` Jose E. Marchesi
2023-08-19 17:42 ` [RFC 12/14] Nuke cgen-call-with-debugging and cgen-debugging-stack-start Tom Tromey
2023-08-19 17:42 ` [RFC 13/14] Load macros before uses Tom Tromey
2023-08-19 17:42 ` [RFC 14/14] Remove pprint.scm and cos-pprint.scm Tom Tromey
2023-08-20  8:03 ` [RFC 00/14] Port to Guile 3.0 Jose E. Marchesi
2023-08-20 17:26   ` Frank Ch. Eigler
2023-08-20 19:52     ` Tom Tromey
2023-08-21  1:38       ` Frank Ch. Eigler
2023-08-21 13:06 ` Julian Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8daqgdm.fsf@gnu.org \
    --to=jemarch@gnu.org \
    --cc=cgen@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).