public inbox for cgen@sourceware.org
 help / color / mirror / Atom feed
From: Ben Elliston <bje@redhat.com>
To: Doug Evans <dje@transmeta.com>
Cc: cgen@sources.redhat.com, hp@axis.com
Subject: Re: m32r port breakage
Date: Tue, 17 Dec 2002 15:43:00 -0000	[thread overview]
Message-ID: <m3pts05i0p.fsf@scooby.brisbane.redhat.com> (raw)
In-Reply-To: <200212100838.AAA12330@xris-athlon.transmeta.com>

>>>>> "Doug" == Doug Evans <dje@transmeta.com> writes:

  Doug> Yes, it's been ages since I've looked at the m32r port, but
  Doug> it's the one I like to use when playing with things.
  Doug> Hans-Peter has a patch he wants to go in and before it has my
  Doug> blessing I want to play with it on a real port.

  Doug> This patch breaks the m32r simulator.

  Doug> 2001-04-02  Ben Elliston  <bje@redhat.com>
	
  Doug> 	* sim-decode.scm (@prefix@_init_idesc_table): Compute tabsize
  Doug> 	using the size of the table and its elements.
  Doug> 	(-gen-decode-insn-globals): Define the idesc table's size to be
  Doug> 	the last instruction enum plus one, not @PREFIX@_INSN_MAX.
  Doug> 	* sim-model.scm (-gen-mach-defns): Define CPU_MAX_INSNS as the
  Doug> 	last instruction enum plus one, not @CPU@_INSN_MAX.

  Doug> Why was @PREFIX@_INSN_MAX replaced with "last instruction enum plus one"?

A port I was doing had an instruction called "MAX" that generated the
symbol @PREFIX@_INSN_MAX.  Rather than change the name of the sentinel
value, I decided to clean this up to avoid any further problems.  I
guess I got carried away. :-( Perhaps you could change the sentinel
value's name to @PREFIX@_INSN__MAX?

Ben

  reply	other threads:[~2002-12-17 23:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-10  0:38 Doug Evans
2002-12-17 15:43 ` Ben Elliston [this message]
2002-12-18  9:10   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pts05i0p.fsf@scooby.brisbane.redhat.com \
    --to=bje@redhat.com \
    --cc=cgen@sources.redhat.com \
    --cc=dje@transmeta.com \
    --cc=hp@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).