public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: STABLE3 - qdisk: fix pid check in shutdown operation
@ 2009-02-26  8:59 Fabio M. Di Nitto
  0 siblings, 0 replies; only message in thread
From: Fabio M. Di Nitto @ 2009-02-26  8:59 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=ad81ca710d21bd6623fba9dc8900169c0af2264e
Commit:        ad81ca710d21bd6623fba9dc8900169c0af2264e
Parent:        9ad630fd9402c1820d758ed12f41bceb8a12eeb6
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Thu Feb 26 09:57:47 2009 +0100
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Thu Feb 26 09:57:47 2009 +0100

qdisk: fix pid check in shutdown operation

this will avoid an unnecessary loop in the shutdown operation
when qdisk is dead between pid check and kill operation.

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 cman/init.d/qdiskd.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cman/init.d/qdiskd.in b/cman/init.d/qdiskd.in
index e7e8c74..f2512ba 100644
--- a/cman/init.d/qdiskd.in
+++ b/cman/init.d/qdiskd.in
@@ -88,9 +88,9 @@ case "$1" in
 	pid="$(pidof qdiskd)"
 	while [ -n "$pid" ] && [ $retries -lt 5 ]; do
 		kill $pid 2>&1
-		pid="$(pidof qdiskd)"
 		sleep 1
 		((retries++))
+		pid="$(pidof qdiskd)"
 	done
 	if [ -z "$(pidof qdiskd)" ]; then
 		success


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-02-26  8:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-26  8:59 cluster: STABLE3 - qdisk: fix pid check in shutdown operation Fabio M. Di Nitto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).