public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: RHEL53 - rgmanager: Remove sleep in startup of event thread
@ 2009-03-23 14:50 Lon Hohberger
  0 siblings, 0 replies; only message in thread
From: Lon Hohberger @ 2009-03-23 14:50 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=309670a1a55875cee4d24a31a6dc8d5a5ce2d5d4
Commit:        309670a1a55875cee4d24a31a6dc8d5a5ce2d5d4
Parent:        3f987399dbe8fcb2fd9727094ffd7d861cc0f67c
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Thu Mar 5 16:23:33 2009 -0500
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Thu Mar 5 16:23:33 2009 -0500

rgmanager: Remove sleep in startup of event thread

There's no reason to sleep here, and it delays processing
of potentially important events.

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/rg_event.c |   13 +++----------
 1 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/rgmanager/src/daemons/rg_event.c b/rgmanager/src/daemons/rg_event.c
index d2c7cd3..c63f26c 100644
--- a/rgmanager/src/daemons/rg_event.c
+++ b/rgmanager/src/daemons/rg_event.c
@@ -64,8 +64,8 @@ event_table_t *master_event_table = NULL;
 void
 set_transition_throttling(int nsecs)
 {
-	if (nsecs < 0)
-		nsecs = 0;
+	if (nsecs < 1)
+		nsecs = 1;
 	transition_throttling = nsecs;
 }
 
@@ -396,19 +396,12 @@ _event_thread_f(void __attribute__ ((unused)) *arg)
 	struct timespec expire;
 	int notice = 0, count = 0;
 
-	/* Event thread usually doesn't hang around.  When it's
-   	   spawned, sleep for this many seconds in order to let
-   	   some events queue up */
-	if (transition_throttling && !central_events) {
-		sleep(transition_throttling);
-	}
-
 	while (1) {
 		pthread_mutex_lock(&event_queue_mutex);
 		ev = event_queue;
 		if (!ev && !central_events) {
 			gettimeofday(&now, NULL);
-			expire.tv_sec = now.tv_sec + 5;
+			expire.tv_sec = now.tv_sec + transition_throttling;
 			expire.tv_nsec = now.tv_usec * 1000;
 			pthread_cond_timedwait(&event_queue_cond,
 						&event_queue_mutex,


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-03-23 14:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-23 14:50 cluster: RHEL53 - rgmanager: Remove sleep in startup of event thread Lon Hohberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).