public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: RHEL5 - rgmanager: Fix segfault from missing initializers Date: Wed, 08 Apr 2009 20:52:00 -0000 [thread overview] Message-ID: <20090408205139.49ABA120339@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=d5dba53a3bc5c20629b449bee5e3b0be4c71b538 Commit: d5dba53a3bc5c20629b449bee5e3b0be4c71b538 Parent: edab820147b90a2190f3d7487f28a35040f667a0 Author: Lon Hohberger <lhh@redhat.com> AuthorDate: Wed Apr 8 16:49:04 2009 -0400 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Wed Apr 8 16:50:40 2009 -0400 rgmanager: Fix segfault from missing initializers If the sets are empty or malloc fails, there is a chance that the set lengths will not be zero like they should, causing a segfault. Signed-off-by: Lon Hohberger <lhh@redhat.com> --- rgmanager/src/daemons/groups.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c index 6d2ce38..94fa303 100644 --- a/rgmanager/src/daemons/groups.c +++ b/rgmanager/src/daemons/groups.c @@ -430,9 +430,9 @@ check_depend_safe(char *rg_name) int check_rdomain_crash(char *svcName) { - int *nodes = NULL, nodecount; - int *fd_nodes = NULL, fd_nodecount, fl; - int *isect = NULL, icount; + int *nodes = NULL, nodecount = 0; + int *fd_nodes = NULL, fd_nodecount = 0, fl = 0; + int *isect = NULL, icount = 0; char fd_name[256]; if (_group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)
reply other threads:[~2009-04-08 20:52 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090408205139.49ABA120339@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).