public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: RHEL48 - rgmanager: Fix segfault from missing initializers
@ 2009-04-08 21:00 Lon Hohberger
  0 siblings, 0 replies; only message in thread
From: Lon Hohberger @ 2009-04-08 21:00 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=710344770021dd05036cbea66da3e5213c0904e7
Commit:        710344770021dd05036cbea66da3e5213c0904e7
Parent:        c1ec78cd859a799199dbce4135074769f62362ce
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Wed Apr 8 16:49:04 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Wed Apr 8 16:58:53 2009 -0400

rgmanager: Fix segfault from missing initializers

If the sets are empty or malloc fails, there is
a chance that the set lengths will not be zero
like they should, causing a segfault.

Only happens w/ previous patch for bug #428108

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/groups.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/rgmanager/src/daemons/groups.c b/rgmanager/src/daemons/groups.c
index a0816d5..f26c0d4 100644
--- a/rgmanager/src/daemons/groups.c
+++ b/rgmanager/src/daemons/groups.c
@@ -435,9 +435,9 @@ check_rdomain_crash(char *svcName)
 	set_type_t *nodes = NULL;
 	set_type_t *fd_nodes = NULL;
 	set_type_t *isect = NULL;
-	int nodecount;
-	int fd_nodecount, fl;
-	int icount;
+	int nodecount = 0;
+	int fd_nodecount = 0, fl = 0;
+	int icount = 0;
 	char fd_name[256];
 
 	if (group_property(svcName, "domain", fd_name, sizeof(fd_name)) != 0)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-08 21:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-08 21:00 cluster: RHEL48 - rgmanager: Fix segfault from missing initializers Lon Hohberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).