cluster: RHEL5 - rgmanager: Fix up nfsclient tmp files

cluster: RHEL5 - rgmanager: Fix up nfsclient tmp files

[Lon Hohberger]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=684b86aa704e5a7316c17501eb9d3e2f59d681b5
Commit:        684b86aa704e5a7316c17501eb9d3e2f59d681b5
Parent:        c3ca8bc855e3b01c0ca6e169b0d68eee622983e2
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Thu May 21 10:20:23 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Thu May 21 10:27:58 2009 -0400

rgmanager: Fix up nfsclient tmp files

* Randomize temporary file name.
* Disable nfs client caching by default due to
  bad location of cache file.

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/resources/nfsclient.sh |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/rgmanager/src/resources/nfsclient.sh b/rgmanager/src/resources/nfsclient.sh
index 0570a7b..2aeee78 100755
--- a/rgmanager/src/resources/nfsclient.sh
+++ b/rgmanager/src/resources/nfsclient.sh
@@ -130,6 +130,9 @@ meta_data()
 	    <content type="string"/>
 	</parameter>
 
+<!-- Disabled until we can cleanly move the cache location.
+     Uncomment to reenable.
+
 	<parameter name="use_cache" inherit="service%nfs_client_cache">
             <longdesc lang="en">
 	   	On systems with large numbers of exports, a performance
@@ -149,7 +152,7 @@ meta_data()
             </shortdesc>
 	    <content type="integer"/>
 	</parameter>
-
+-->
 
     </parameters>
 
@@ -363,6 +366,7 @@ status|monitor)
 
 		#
 		# For large #s of exports, we need to cache the information
+		# This location is not secure.
 		#
 		tmpfn=/tmp/nfsclient-status-cache-$OCF_RESKEY_service_name
 
@@ -377,7 +381,7 @@ status|monitor)
 		#
 		# Create a different file if this is a separate instance
 		#
-		tmpfn=/tmp/nfsclient-status-cache-$$
+		tmpfn=$(mktemp /tmp/nfsclient-status-cache.XXXXXX)
 	fi
 
 	if ! [ -f "$tmpfn" ] || [ $delta -gt 30 ]; then