public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: STABLE2 - GFS2: gfs2_edit savemeta wasn't saving ea sub-blocks
@ 2009-06-16 20:12 Bob Peterson
0 siblings, 0 replies; only message in thread
From: Bob Peterson @ 2009-06-16 20:12 UTC (permalink / raw)
To: cluster-cvs-relay
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=a53fabd00c33987bb7247199d7f313d0ad2ada46
Commit: a53fabd00c33987bb7247199d7f313d0ad2ada46
Parent: 81a9848c2996ab852fe6ceceba65bd84d820acb7
Author: Bob Peterson <rpeterso@redhat.com>
AuthorDate: Tue Jun 16 14:46:09 2009 -0500
Committer: Bob Peterson <rpeterso@redhat.com>
CommitterDate: Tue Jun 16 15:10:43 2009 -0500
GFS2: gfs2_edit savemeta wasn't saving ea sub-blocks
bz 503529
Indirect extended attribute blocks may have sub-blocks, and those
weren't getting saved. This adds that capability.
---
gfs2/edit/savemeta.c | 72 +++++++++++++++++++++++++++-----------------------
1 files changed, 39 insertions(+), 33 deletions(-)
diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c
index 64d2bd1..6cb9f39 100644
--- a/gfs2/edit/savemeta.c
+++ b/gfs2/edit/savemeta.c
@@ -187,8 +187,9 @@ int save_block(int fd, int out_fd, uint64_t blk)
char *p;
if (blk > last_fs_block) {
- fprintf(stderr, "\nWarning: bad block pointer ignored in "
- "block (block %llu (%llx))",
+ fprintf(stderr, "\nWarning: bad block pointer '0x%llx' "
+ "ignored in block (block %llu (%llx))",
+ (unsigned long long)blk,
(unsigned long long)block, (unsigned long long)block);
return 0;
}
@@ -222,6 +223,35 @@ int save_block(int fd, int out_fd, uint64_t blk)
}
/*
+ * save_ea_block - save off an extended attribute block
+ */
+void save_ea_block(int out_fd, struct gfs2_buffer_head *metabh)
+{
+ int i, e, ea_len = sbd.bsize;
+ struct gfs2_ea_header ea;
+
+ for (e = sizeof(struct gfs2_meta_header); e < sbd.bsize; e += ea_len) {
+ uint64_t blk, *b;
+ int charoff;
+
+ gfs2_ea_header_in(&ea, metabh->b_data + e);
+ for (i = 0; i < ea.ea_num_ptrs; i++) {
+ charoff = e + ea.ea_name_len +
+ sizeof(struct gfs2_ea_header) +
+ sizeof(uint64_t) - 1;
+ charoff /= sizeof(uint64_t);
+ b = (uint64_t *)(metabh->b_data);
+ b += charoff + i;
+ blk = be64_to_cpu(*b);
+ save_block(sbd.device_fd, out_fd, blk);
+ }
+ if (!ea.ea_rec_len)
+ break;
+ ea_len = ea.ea_rec_len;
+ }
+}
+
+/*
* save_indirect_blocks - save all indirect blocks for the given buffer
*/
void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
@@ -229,7 +259,7 @@ void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
{
uint64_t old_block = 0, indir_block;
uint64_t *ptr;
- int head_size;
+ int head_size, blktype;
struct gfs2_buffer_head *nbh;
head_size = (hgt > 1 ?
@@ -244,7 +274,12 @@ void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
if (indir_block == old_block)
continue;
old_block = indir_block;
- save_block(sbd.device_fd, out_fd, indir_block);
+ blktype = save_block(sbd.device_fd, out_fd, indir_block);
+ if (blktype == GFS2_METATYPE_EA) {
+ nbh = bread(&sbd.buf_list, indir_block);
+ save_ea_block(out_fd, nbh);
+ brelse(nbh, not_updated);
+ }
if (height != hgt) { /* If not at max height */
nbh = bread(&sbd.buf_list, indir_block);
osi_list_add_prev(&nbh->b_altlist,
@@ -255,35 +290,6 @@ void save_indirect_blocks(int out_fd, osi_list_t *cur_list,
}
/*
- * save_ea_block - save off an extended attribute block
- */
-void save_ea_block(int out_fd, struct gfs2_buffer_head *metabh)
-{
- int i, e, ea_len = sbd.bsize;
- struct gfs2_ea_header ea;
-
- for (e = sizeof(struct gfs2_meta_header); e < sbd.bsize; e += ea_len) {
- uint64_t blk, *b;
- int charoff;
-
- gfs2_ea_header_in(&ea, metabh->b_data + e);
- for (i = 0; i < ea.ea_num_ptrs; i++) {
- charoff = e + ea.ea_name_len +
- sizeof(struct gfs2_ea_header) +
- sizeof(uint64_t) - 1;
- charoff /= sizeof(uint64_t);
- b = (uint64_t *)(metabh->b_data);
- b += charoff + i;
- blk = be64_to_cpu(*b);
- save_block(sbd.device_fd, out_fd, blk);
- }
- if (!ea.ea_rec_len)
- break;
- ea_len = ea.ea_rec_len;
- }
-}
-
-/*
* save_inode_data - save off important data associated with an inode
*
* out_fd - destination file descriptor
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-06-16 20:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-16 20:12 cluster: STABLE2 - GFS2: gfs2_edit savemeta wasn't saving ea sub-blocks Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).