cluster: RHEL4 - rgmanager: Fix small memory leak

cluster: RHEL4 - rgmanager: Fix small memory leak

[Lon Hohberger]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=2707f7fefd49f07a89f52b093be4bef86d2ccf77
Commit:        2707f7fefd49f07a89f52b093be4bef86d2ccf77
Parent:        6b4e6f18cfa7a03b1ee1008a019aad077e3954fc
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Fri Jun 19 22:59:53 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 22 14:12:30 2009 -0400

rgmanager: Fix small memory leak

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/slang_event.c |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c
index 6e17db0..920752d 100644
--- a/rgmanager/src/daemons/slang_event.c
+++ b/rgmanager/src/daemons/slang_event.c
@@ -424,16 +424,23 @@ out:
 /**
   get_service_property(service_name, property)
  */
-char *
+static void
 sl_service_property(char *svcName, char *prop)
 {
 	char buf[96];
+	char *ret;
 
 	if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0)
-		return NULL;
+		return;
 
 	/* does this work or do I have to push a malloce'd string? */
-	return strdup(buf);
+	ret = strdup(buf);
+	if (SLang_push_malloced_string(ret) < 0) {
+		SLang_verror(SL_RunTime_Error,
+			     (char *)"%s: Failed to push %s property of %s",
+			     __FUNCTION__, prop, svcName);
+		free(ret);
+	}
 }