cluster: RHEL53 - cman: send fewer messages for each state transition.

cluster: RHEL53 - cman: send fewer messages for each state transition.

[Chris Feist]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=f61bf5dedd20f77607766dcdfa3f177c547e6a92
Commit:        f61bf5dedd20f77607766dcdfa3f177c547e6a92
Parent:        a5fb1d3e2b6178bf818e4a1246b0d9ad9ad8ffee
Author:        Christine Caulfield <ccaulfie@redhat.com>
AuthorDate:    Tue Jan 20 14:14:26 2009 +0000
Committer:     Chris Feist <cfeist@redhat.com>
CommitterDate: Tue Jun 23 12:18:35 2009 -0500

cman: send fewer messages for each state transition.

Only recalculate quorum (and tell everyone the result) if a node state
has actually changed.

bz#506768
Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
---
 cman/daemon/commands.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/cman/daemon/commands.c b/cman/daemon/commands.c
index 3bd9c66..945268a 100644
--- a/cman/daemon/commands.c
+++ b/cman/daemon/commands.c
@@ -1709,6 +1709,8 @@ static void do_process_transition(int nodeid, char *data, int len)
 {
 	struct cl_transmsg *msg = (struct cl_transmsg *)data;
 	struct cluster_node *node;
+	unsigned int old_expected;
+	nodestate_t old_state;
 
 	if (valid_transition_msg(nodeid, msg) != 0) {
 		P_MEMB("Transition message from %d does not match current config - should quit ?\n", nodeid);
@@ -1726,6 +1728,8 @@ static void do_process_transition(int nodeid, char *data, int len)
 
 	node = find_node_by_nodeid(nodeid);
 	assert(node);
+	old_expected = node->expected_votes;
+	old_state = node->state;
 
 	P_MEMB("Got TRANSITION message. msg->flags=%x, node->flags=%x, first_trans=%d\n",
 	       msg->flags, node->flags, msg->first_trans);
@@ -1785,7 +1789,9 @@ static void do_process_transition(int nodeid, char *data, int len)
 
 	/* Take into account any new expected_votes value that the new node has */
 	node->expected_votes = msg->expected_votes;
-	recalculate_quorum(0, 0);
+
+	if (old_state != node->state || old_expected != node->expected_votes)
+		recalculate_quorum(0, 0);
 
 	if (node->fence_agent && msg->fence_agent[0] && strcmp(node->fence_agent, msg->fence_agent))
 	{