From: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
To: crossgcc@sourceware.org
Cc: Zhenqiang Chen <zhenqiang.chen@linaro.org>
Subject: Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config
Date: Tue, 22 Nov 2011 17:24:00 -0000 [thread overview]
Message-ID: <201111221823.56129.yann.morin.1998@anciens.enib.fr> (raw)
In-Reply-To: <4ECB8D46.1040002@linaro.org>
Zhenqiang, All,
On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321523984 -28800
> # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65
> # Parent 986e1c75432aad60ae3239767198c653c08c01af
> binutils/binutils: Add --disable-nls config when
> option "Enable nls" is not selected.
>
> Reviewed-by: Michael Hope
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>
> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
> --- a/scripts/build/binutils/binutils.sh
> +++ b/scripts/build/binutils/binutils.sh
> @@ -62,6 +62,8 @@
> [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> fi
>
> + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
Shoudn't we also force --enable-nls otherwise?
if [ "${CT_TOOLCHAIN_ENABLE_NLS}" = "y" ]; then
extra_config+=("--enable-nls")
else
extra_config+=("--disable-nls")
fi
Not sure what the default is (I guess enabled is, but better safe than sorry).
Otherwise, good.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2011-11-22 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:54 Zhenqiang Chen
2011-11-22 17:24 ` Yann E. MORIN [this message]
2011-11-22 20:13 ` Michael Hope
2011-11-22 22:00 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221823.56129.yann.morin.1998@anciens.enib.fr \
--to=yann.morin.1998@anciens.enib.fr \
--cc=crossgcc@sourceware.org \
--cc=zhenqiang.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).