public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] debug/gdb: add extra config for gdb cross
@ 2011-11-23 11:41 Zhenqiang Chen
  2011-11-23 21:08 ` Michael Hope
  2011-11-23 22:59 ` Yann E. MORIN
  0 siblings, 2 replies; 4+ messages in thread
From: Zhenqiang Chen @ 2011-11-23 11:41 UTC (permalink / raw)
  To: yann.morin.1998; +Cc: crossgcc

# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1322025327 -28800
# Node ID e3a6a636cfa9013ddd0855ca9eb8d3a35dad3249
# Parent  2f4e3c312b659422e4a9950f13a0fc507b97c1fd
debug/gdb: add extra config for gdb cross.

Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>

diff --git a/config/debug/gdb.in.cross b/config/debug/gdb.in.cross
--- a/config/debug/gdb.in.cross
+++ b/config/debug/gdb.in.cross
@@ -39,4 +39,11 @@
        have been reports of problems when linking gdb to the static
        libpython.a. This should be fixed in gdb >=7.3. YMMV.

+config GDB_CROSS_EXTRA_CONFIG_ARRAY
+    string
+    prompt "Extra config for gdb cross"
+    default ""
+    help
+      Extra flags to pass onto ./configure when configuring the gdb cross.
+
  endif # GDB_CROSS
diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
--- a/scripts/build/debug/300-gdb.sh
+++ b/scripts/build/debug/300-gdb.sh
@@ -147,7 +147,8 @@
              --with-sysroot="${CT_SYSROOT_DIR}"          \
              --with-expat=yes                            \
              --disable-werror                            \
-            "${cross_extra_config[@]}"
+            "${cross_extra_config[@]}"                  \
+            "${CT_GDB_CROSS_EXTRA_CONFIG_ARRAY[@]}"

          CT_DoLog EXTRA "Building cross-gdb"
          CT_DoExecLog ALL make ${JOBSFLAGS}

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] debug/gdb: add extra config for gdb cross
  2011-11-23 11:41 [PATCH] debug/gdb: add extra config for gdb cross Zhenqiang Chen
@ 2011-11-23 21:08 ` Michael Hope
  2011-11-23 21:22   ` Yann E. MORIN
  2011-11-23 22:59 ` Yann E. MORIN
  1 sibling, 1 reply; 4+ messages in thread
From: Michael Hope @ 2011-11-23 21:08 UTC (permalink / raw)
  To: Zhenqiang Chen; +Cc: yann.morin.1998, crossgcc

On Thu, Nov 24, 2011 at 12:40 AM, Zhenqiang Chen
<zhenqiang.chen@linaro.org> wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1322025327 -28800
> # Node ID e3a6a636cfa9013ddd0855ca9eb8d3a35dad3249
> # Parent  2f4e3c312b659422e4a9950f13a0fc507b97c1fd
> debug/gdb: add extra config for gdb cross.
>
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>
> diff --git a/config/debug/gdb.in.cross b/config/debug/gdb.in.cross
> --- a/config/debug/gdb.in.cross
> +++ b/config/debug/gdb.in.cross
> @@ -39,4 +39,11 @@
>       have been reports of problems when linking gdb to the static
>       libpython.a. This should be fixed in gdb >=7.3. YMMV.
>
> +config GDB_CROSS_EXTRA_CONFIG_ARRAY
> +    string
> +    prompt "Extra config for gdb cross"

Should this be "Cross-gdb extra config" to be consistent with the
other arrays in binutils, glibc, and gcc?

> +    default ""
> +    help
> +      Extra flags to pass onto ./configure when configuring the gdb cross.
> +
>  endif # GDB_CROSS
> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
> --- a/scripts/build/debug/300-gdb.sh
> +++ b/scripts/build/debug/300-gdb.sh
> @@ -147,7 +147,8 @@
>             --with-sysroot="${CT_SYSROOT_DIR}"          \
>             --with-expat=yes                            \
>             --disable-werror                            \
> -            "${cross_extra_config[@]}"
> +            "${cross_extra_config[@]}"                  \

Huh.  The trailing \ looks fine in Thunderbird but is one character
short in gmail's view original.

-- Michael

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] debug/gdb: add extra config for gdb cross
  2011-11-23 21:08 ` Michael Hope
@ 2011-11-23 21:22   ` Yann E. MORIN
  0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2011-11-23 21:22 UTC (permalink / raw)
  To: Michael Hope; +Cc: Zhenqiang Chen, crossgcc

Michael, Zhenqiang, All,

On Wednesday 23 November 2011 22:07:37 Michael Hope wrote:
> On Thu, Nov 24, 2011 at 12:40 AM, Zhenqiang Chen
> <zhenqiang.chen@linaro.org> wrote:
> > # HG changeset patch
> > # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> > # Date 1322025327 -28800
> > # Node ID e3a6a636cfa9013ddd0855ca9eb8d3a35dad3249
> > # Parent  2f4e3c312b659422e4a9950f13a0fc507b97c1fd
> > debug/gdb: add extra config for gdb cross.
> >
> > Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
> >
> > diff --git a/config/debug/gdb.in.cross b/config/debug/gdb.in.cross
> > --- a/config/debug/gdb.in.cross
> > +++ b/config/debug/gdb.in.cross
> > @@ -39,4 +39,11 @@
> >       have been reports of problems when linking gdb to the static
> >       libpython.a. This should be fixed in gdb >=7.3. YMMV.
> >
> > +config GDB_CROSS_EXTRA_CONFIG_ARRAY
> > +    string
> > +    prompt "Extra config for gdb cross"
> 
> Should this be "Cross-gdb extra config" to be consistent with the
> other arrays in binutils, glibc, and gcc?

Yes, I'll change here before committing.

> > +    default ""
> > +    help
> > +      Extra flags to pass onto ./configure when configuring the gdb cross.
> > +
> >  endif # GDB_CROSS
> > diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
> > --- a/scripts/build/debug/300-gdb.sh
> > +++ b/scripts/build/debug/300-gdb.sh
> > @@ -147,7 +147,8 @@
> >             --with-sysroot="${CT_SYSROOT_DIR}"          \
> >             --with-expat=yes                            \
> >             --disable-werror                            \
> > -            "${cross_extra_config[@]}"
> > +            "${cross_extra_config[@]}"                  \
> 
> Huh.  The trailing \ looks fine in Thunderbird but is one character
> short in gmail's view original.

I looked at the raw message, and somehow a leading space is added to every
lines that already start with a space.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] debug/gdb: add extra config for gdb cross
  2011-11-23 11:41 [PATCH] debug/gdb: add extra config for gdb cross Zhenqiang Chen
  2011-11-23 21:08 ` Michael Hope
@ 2011-11-23 22:59 ` Yann E. MORIN
  1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2011-11-23 22:59 UTC (permalink / raw)
  To: crossgcc; +Cc: Zhenqiang Chen

Zhenqiang, All,

On Wednesday 23 November 2011 12:40:59 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1322025327 -28800
> # Node ID e3a6a636cfa9013ddd0855ca9eb8d3a35dad3249
> # Parent  2f4e3c312b659422e4a9950f13a0fc507b97c1fd
> debug/gdb: add extra config for gdb cross.

Applied as #258160822e35. Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-11-23 22:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-23 11:41 [PATCH] debug/gdb: add extra config for gdb cross Zhenqiang Chen
2011-11-23 21:08 ` Michael Hope
2011-11-23 21:22   ` Yann E. MORIN
2011-11-23 22:59 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).