public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] cc/gcc: pass --with-float to configure
@ 2011-12-12 20:28 Benoît Thébaudeau
  2011-12-12 21:57 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Benoît Thébaudeau @ 2011-12-12 20:28 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
# Date 1323721590 -3600
# Node ID bd159438bf3a1dae64e2bbffd6eaaa19f72fe4ad
# Parent  7a5ee8d36a1de21f8cb1e1cd138c0f066f0ec8c2
cc/gcc: pass --with-float to configure

The --with-float configure option defines the default -mhard-float, -msoft-float
or -mfloat-abi option of the built GCC. The --with-float option is ignored if
any of the latter options is passed to GCC.

Currently, these options are passed to GCC through the C(XX)FLAGS_FOR_TARGET
environment variables, but these variables are only used to build GCC's internal
stuff and libraries. Hence, --with-float has to be passed to GCC's configure to
define the default options of the final GCC.

Signed-off-by: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>

diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -311,6 +311,7 @@
         ${CC_CORE_SYSROOT_ARG}                      \
         "${extra_config[@]}"                        \
         --enable-languages="${lang_opt}"            \
+        ${CT_ARCH_WITH_FLOAT}                       \
         "${CT_CC_CORE_EXTRA_CONFIG_ARRAY[@]}"
 
     if [ "${build_libgcc}" = "yes" ]; then
@@ -622,6 +623,7 @@
         --with-local-prefix="${CT_SYSROOT_DIR}"     \
         --enable-c99                                \
         --enable-long-long                          \
+        ${CT_ARCH_WITH_FLOAT}                       \
         "${CT_CC_EXTRA_CONFIG_ARRAY[@]}"
 
     if [ "${CT_CANADIAN}" = "y" ]; then

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cc/gcc: pass --with-float to configure
  2011-12-12 20:28 [PATCH] cc/gcc: pass --with-float to configure Benoît Thébaudeau
@ 2011-12-12 21:57 ` Yann E. MORIN
  2011-12-12 22:29   ` Benoît Thébaudeau
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2011-12-12 21:57 UTC (permalink / raw)
  To: crossgcc; +Cc: Benoît Thébaudeau

Benoît, All,

On Monday 12 December 2011 21:28:29 Benoît Thébaudeau wrote:
> # HG changeset patch
> # User "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
> # Date 1323721590 -3600
> # Node ID bd159438bf3a1dae64e2bbffd6eaaa19f72fe4ad
> # Parent  7a5ee8d36a1de21f8cb1e1cd138c0f066f0ec8c2
> cc/gcc: pass --with-float to configure
> 
> The --with-float configure option defines the default -mhard-float, -msoft-float
> or -mfloat-abi option of the built GCC. The --with-float option is ignored if
> any of the latter options is passed to GCC.
> 
> Currently, these options are passed to GCC through the C(XX)FLAGS_FOR_TARGET
> environment variables, but these variables are only used to build GCC's internal
> stuff and libraries. Hence, --with-float has to be passed to GCC's configure to
> define the default options of the final GCC.

This should be already handled by the code on lines #176 and #439:
    http://crosstool-ng.org/hg/crosstool-ng/file/7a5ee8d36a1d/scripts/build/cc/gcc.sh#l176

176    for tmp in ARCH ABI CPU TUNE FPU FLOAT; do
177         eval tmp="\${CT_ARCH_WITH_${tmp}}"
178         if [ -n "${tmp}" ]; then
179             extra_config+=("${tmp}")
180         fi
181     done

(same code on line #439 for the final gcc)

Isn't it the case for you?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cc/gcc: pass --with-float to configure
  2011-12-12 21:57 ` Yann E. MORIN
@ 2011-12-12 22:29   ` Benoît Thébaudeau
  0 siblings, 0 replies; 3+ messages in thread
From: Benoît Thébaudeau @ 2011-12-12 22:29 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

> This should be already handled by the code on lines #176 and #439:
>     http://crosstool-ng.org/hg/crosstool-ng/file/7a5ee8d36a1d/scripts/build/cc/gcc.sh#l176
>
> 176    for tmp in ARCH ABI CPU TUNE FPU FLOAT; do
> 177         eval tmp="\${CT_ARCH_WITH_${tmp}}"
> 178         if [ -n "${tmp}" ]; then
> 179             extra_config+=("${tmp}")
> 180         fi
> 181     done
>
> (same code on line #439 for the final gcc)
>
> Isn't it the case for you?

Yes, my bad. I missed that part. Sorry for the noise.

Best regards,
Benoît Thébaudeau

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-12-12 22:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-12 20:28 [PATCH] cc/gcc: pass --with-float to configure Benoît Thébaudeau
2011-12-12 21:57 ` Yann E. MORIN
2011-12-12 22:29   ` Benoît Thébaudeau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).