public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] newlib: fix extract process for custom version
@ 2014-02-25 18:09 Trevor Woerner
  2014-02-25 18:33 ` Trevor Woerner
  0 siblings, 1 reply; 3+ messages in thread
From: Trevor Woerner @ 2014-02-25 18:09 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User Trevor Woerner <trevor.woerner@linaro.org>
# Date 1393351239 18000
#      Tue Feb 25 13:00:39 2014 -0500
# Node ID 3cb8019727c2b5af670146f118152a6b948d4bb6
# Parent  9321d9d7af9bd605eec2811b6703392331db3469
newlib: fix extract process for custom version

If the user specifies the use of a custom newlib version, the logic in the
extract function was reversed, so this step would fail.

diff -r 9321d9d7af9b -r 3cb8019727c2 scripts/build/libc/newlib.sh
--- a/scripts/build/libc/newlib.sh	Thu Feb 20 18:23:08 2014 +0000
+++ b/scripts/build/libc/newlib.sh	Tue Feb 25 13:00:39 2014 -0500
@@ -29,7 +29,7 @@
 
 do_libc_extract() {
     # If using custom directory location, nothing to do
-    if [    "${CT_LIBC_NEWLIB_CUSTOM}" != "y"            \
+    if [ "${CT_LIBC_NEWLIB_CUSTOM}" = "y"            \
          -a -d "${CT_SRC_DIR}/newlib-${CT_LIBC_VERSION}" ]; then
         return 0
     fi

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] newlib: fix extract process for custom version
  2014-02-25 18:09 [PATCH] newlib: fix extract process for custom version Trevor Woerner
@ 2014-02-25 18:33 ` Trevor Woerner
  0 siblings, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2014-02-25 18:33 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

On 02/25/14 13:09, Trevor Woerner wrote:
> # HG changeset patch
> # User Trevor Woerner <trevor.woerner@linaro.org>
> # Date 1393351239 18000
> #      Tue Feb 25 13:00:39 2014 -0500
> # Node ID 3cb8019727c2b5af670146f118152a6b948d4bb6
> # Parent  9321d9d7af9bd605eec2811b6703392331db3469
> newlib: fix extract process for custom version
>

Whoops! Looks like I forgot the SoB line... resending.

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] newlib: fix extract process for custom version
@ 2014-02-25 18:36 Trevor Woerner
  0 siblings, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2014-02-25 18:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc, patches

# HG changeset patch
# User Trevor Woerner <trevor.woerner@linaro.org>
# Date 1393353288 18000
#      Tue Feb 25 13:34:48 2014 -0500
# Node ID c727adf1b7bd2c1e891db512871dbe7b26797fa6
# Parent  9321d9d7af9bd605eec2811b6703392331db3469
newlib: fix extract process for custom version

If the user specifies the use of a custom newlib version, the logic in the
extract function was reversed, so this step would fail.

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>

diff -r 9321d9d7af9b -r c727adf1b7bd scripts/build/libc/newlib.sh
--- a/scripts/build/libc/newlib.sh	Thu Feb 20 18:23:08 2014 +0000
+++ b/scripts/build/libc/newlib.sh	Tue Feb 25 13:34:48 2014 -0500
@@ -29,7 +29,7 @@
 
 do_libc_extract() {
     # If using custom directory location, nothing to do
-    if [    "${CT_LIBC_NEWLIB_CUSTOM}" != "y"            \
+    if [ "${CT_LIBC_NEWLIB_CUSTOM}" = "y"            \
          -a -d "${CT_SRC_DIR}/newlib-${CT_LIBC_VERSION}" ]; then
         return 0
     fi

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-25 18:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-25 18:09 [PATCH] newlib: fix extract process for custom version Trevor Woerner
2014-02-25 18:33 ` Trevor Woerner
2014-02-25 18:36 Trevor Woerner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).