public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] libc/newlib: fix configure error
@ 2011-12-07  2:18 Zhenqiang Chen
  2011-12-07  3:17 ` Mike Frysinger
  2011-12-11 21:25 ` Yann E. MORIN
  0 siblings, 2 replies; 7+ messages in thread
From: Zhenqiang Chen @ 2011-12-07  2:18 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

exporting patch:
# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1323223997 -28800
# Node ID f4ac9aa016c90484868940a8077ecb035ab4c26f
# Parent  cf509170838f4e289fe25617e3f3db1d6d6ffc41
libc/newlib: fix configure error

Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>

diff -r cf509170838f -r f4ac9aa016c9 scripts/build/libc/newlib.sh
--- a/scripts/build/libc/newlib.sh      Wed Nov 30 12:07:59 2011 +0100
+++ b/scripts/build/libc/newlib.sh      Wed Dec 07 10:13:17 2011 +0800
@@ -98,7 +98,8 @@
     AR=${CT_TARGET}-ar                                  \
     RANLIB=${CT_TARGET}-ranlib                          \
     "${CT_SRC_DIR}/newlib-$(libc_newlib_version)/configure" \
-        --host=${CT_BUILD}                              \
+        --build=${CT_BUILD}                             \
+        --host=${CT_HOST}                               \
         --target=${CT_TARGET}                           \
         --prefix=${CT_PREFIX_DIR}                       \
         "${newlib_opts[@]}"                             \

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-07  2:18 [PATCH] libc/newlib: fix configure error Zhenqiang Chen
@ 2011-12-07  3:17 ` Mike Frysinger
  2011-12-07  4:46   ` Ralf Corsepius
  2011-12-07  6:01   ` Zhenqiang Chen
  2011-12-11 21:25 ` Yann E. MORIN
  1 sibling, 2 replies; 7+ messages in thread
From: Mike Frysinger @ 2011-12-07  3:17 UTC (permalink / raw)
  To: crossgcc; +Cc: Zhenqiang Chen, Yann E. MORIN

[-- Attachment #1: Type: Text/Plain, Size: 789 bytes --]

On Tuesday 06 December 2011 21:18:16 Zhenqiang Chen wrote:
> --- a/scripts/build/libc/newlib.sh      Wed Nov 30 12:07:59 2011 +0100
> +++ b/scripts/build/libc/newlib.sh      Wed Dec 07 10:13:17 2011 +0800
>
>      AR=${CT_TARGET}-ar                                  \
>      RANLIB=${CT_TARGET}-ranlib                          \
>      "${CT_SRC_DIR}/newlib-$(libc_newlib_version)/configure" \
> -        --host=${CT_BUILD}                              \
> +        --build=${CT_BUILD}                             \
> +        --host=${CT_HOST}                               \
>          --target=${CT_TARGET}                           \

i'd expect newlib to be like glibc and would use:
	--build=${CT_BUILD} --host=${CT_TARGET}

does newlib even use --target= ?  
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-07  3:17 ` Mike Frysinger
@ 2011-12-07  4:46   ` Ralf Corsepius
  2011-12-07  7:57     ` Zhenqiang Chen
  2011-12-07  6:01   ` Zhenqiang Chen
  1 sibling, 1 reply; 7+ messages in thread
From: Ralf Corsepius @ 2011-12-07  4:46 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: crossgcc, Zhenqiang Chen, Yann E. MORIN

On 12/07/2011 04:17 AM, Mike Frysinger wrote:
> On Tuesday 06 December 2011 21:18:16 Zhenqiang Chen wrote:
>> --- a/scripts/build/libc/newlib.sh      Wed Nov 30 12:07:59 2011 +0100
>> +++ b/scripts/build/libc/newlib.sh      Wed Dec 07 10:13:17 2011 +0800
>>
>>       AR=${CT_TARGET}-ar                                  \
>>       RANLIB=${CT_TARGET}-ranlib                          \
>>       "${CT_SRC_DIR}/newlib-$(libc_newlib_version)/configure" \
>> -        --host=${CT_BUILD}                              \
>> +        --build=${CT_BUILD}                             \
>> +        --host=${CT_HOST}                               \
>>           --target=${CT_TARGET}                           \
>
> i'd expect newlib to be like glibc and would use:
> 	--build=${CT_BUILD} --host=${CT_TARGET}
>
> does newlib even use --target= ?

The toplevel configure script does (It is GCC's/binutil's/gdb's unified 
configure script).

The newlib subdir's configure script doesn't.

So .. the answer would depend upon which configure script the patch 
above refers to.


Ralf



--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-07  3:17 ` Mike Frysinger
  2011-12-07  4:46   ` Ralf Corsepius
@ 2011-12-07  6:01   ` Zhenqiang Chen
  1 sibling, 0 replies; 7+ messages in thread
From: Zhenqiang Chen @ 2011-12-07  6:01 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: crossgcc, Yann E. MORIN

> i'd expect newlib to be like glibc and would use:
>        --build=${CT_BUILD} --host=${CT_TARGET}
>

We can not use --host=${CT_TARGET}. Test show it will lead to
configure error for target like arm-none-eabi.

Thanks!
-Zhenqiang

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-07  4:46   ` Ralf Corsepius
@ 2011-12-07  7:57     ` Zhenqiang Chen
  0 siblings, 0 replies; 7+ messages in thread
From: Zhenqiang Chen @ 2011-12-07  7:57 UTC (permalink / raw)
  To: Ralf Corsepius; +Cc: Mike Frysinger, crossgcc, Yann E. MORIN

>
> The toplevel configure script does (It is GCC's/binutil's/gdb's unified
> configure script).
>
> The newlib subdir's configure script doesn't.
>
> So .. the answer would depend upon which configure script the patch above
> refers to.
>
>

In my tests, there is no difference between --host=${CT_HOST} and
--host=${CT_BUILD}. Both will use ${CT_TARGET}-gcc to build the
newlib. So I prefer to use the unified format.

Anyway it is OK for me to keep current configure.

Thanks!
-Zhenqiang

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-07  2:18 [PATCH] libc/newlib: fix configure error Zhenqiang Chen
  2011-12-07  3:17 ` Mike Frysinger
@ 2011-12-11 21:25 ` Yann E. MORIN
  2011-12-12  3:55   ` Zhenqiang Chen
  1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2011-12-11 21:25 UTC (permalink / raw)
  To: crossgcc; +Cc: Zhenqiang Chen

Zhenqiang, All,

On Wednesday 07 December 2011 03:18:16 Zhenqiang Chen wrote:
> exporting patch:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1323223997 -28800
> # Node ID f4ac9aa016c90484868940a8077ecb035ab4c26f
> # Parent  cf509170838f4e289fe25617e3f3db1d6d6ffc41
> libc/newlib: fix configure error
> 
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
> 
> diff -r cf509170838f -r f4ac9aa016c9 scripts/build/libc/newlib.sh
> --- a/scripts/build/libc/newlib.sh      Wed Nov 30 12:07:59 2011 +0100
> +++ b/scripts/build/libc/newlib.sh      Wed Dec 07 10:13:17 2011 +0800
> @@ -98,7 +98,8 @@
>      AR=${CT_TARGET}-ar                                  \
>      RANLIB=${CT_TARGET}-ranlib                          \
>      "${CT_SRC_DIR}/newlib-$(libc_newlib_version)/configure" \
> -        --host=${CT_BUILD}                              \
> +        --build=${CT_BUILD}                             \
> +        --host=${CT_HOST}                               \
>          --target=${CT_TARGET}                           \
>          --prefix=${CT_PREFIX_DIR}                       \
>          "${newlib_opts[@]}"                             \

Can you elaborate on the issue you are trying to fix with this patch?

From my experience, newlib confuses build vs. host vs. target (see the
comment just above the ./configure call). So, I'm a bit reluctant at
applying this patch without more information.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] libc/newlib: fix configure error
  2011-12-11 21:25 ` Yann E. MORIN
@ 2011-12-12  3:55   ` Zhenqiang Chen
  0 siblings, 0 replies; 7+ messages in thread
From: Zhenqiang Chen @ 2011-12-12  3:55 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

> Can you elaborate on the issue you are trying to fix with this patch?
>
> From my experience, newlib confuses build vs. host vs. target (see the
> comment just above the ./configure call). So, I'm a bit reluctant at
> applying this patch without more information.
>

Both current configure and the patched configure work for me.

With current configure, there is some mis-leading when reading
config.log for canadian build. It is OK for me to keep current
configure.

Thanks!
-Zhenqiang

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2011-12-12  3:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-07  2:18 [PATCH] libc/newlib: fix configure error Zhenqiang Chen
2011-12-07  3:17 ` Mike Frysinger
2011-12-07  4:46   ` Ralf Corsepius
2011-12-07  7:57     ` Zhenqiang Chen
2011-12-07  6:01   ` Zhenqiang Chen
2011-12-11 21:25 ` Yann E. MORIN
2011-12-12  3:55   ` Zhenqiang Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).