public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH] Update .gitignore files.
       [not found] <1418061040-3946-1-git-send-email-james.byrne@origamienergy.com>
@ 2014-12-08 18:13 ` Bryan Hundven
  2014-12-08 18:18   ` Bryan Hundven
  0 siblings, 1 reply; 2+ messages in thread
From: Bryan Hundven @ 2014-12-08 18:13 UTC (permalink / raw)
  To: James Byrne; +Cc: crossgcc maillist

James,

On Mon, Dec 8, 2014 at 9:50 AM, James Byrne
<james.byrne@origamienergy.com> wrote:
> The current .gitignore files cause changes to files which are actually part of
> the repository to be ignored. This commit modifies the rules so that this does
> not happen. The files that were affected are:
>
>   config/global/paths.in
>   contrib/gcc-test-suite/Makefile
>   docs/ct-ng.1.in
>   kconfig/Makefile
>
> (as revealed by 'git ls-files --ignored --exclude-standard')
>
> Signed-off-by: James Byrne <james.byrne@origamienergy.com>
> ---
>  .gitignore      | 3 ++-
>  docs/.gitignore | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index 90b516d..7854d8b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -3,11 +3,12 @@ configure
>  autom4te.cache
>  config.log
>  config.status
> -Makefile
> +/Makefile
>  *ct-ng*
>  !ct-ng.comp
>  !ct-ng.in
>  paths.*
> +!paths.in
>  config.gen/
>  .config
>  .config.2
> diff --git a/docs/.gitignore b/docs/.gitignore
> index 53f6ef9..fc05ff2 100644
> --- a/docs/.gitignore
> +++ b/docs/.gitignore
> @@ -1,2 +1,3 @@
>  *ct-ng*.1
>  *ct-ng*.1.gz
> +!ct-ng.1.in
> --
> 1.9.1
>

The patch does fix the files that should not be ignored.
I'd prefer that new patches use github from now on:
    https://github.com/crosstool-ng/crosstool-ng

    https://help.github.com/articles/using-pull-requests/

For one, patchwork is ran on a crontab, so your patch is not
immediately available for me to apply from patchwork. Whereas if a
pull request was opened on github, I'm able to test and apply as soon
as possible.

As of the time of sending this email, the patch is still not available
on patchwork, and I will continue to watch patchwork and wait for it
to be available so I can apply it.

Please use github from now on. :)

-Bryan
(Note to self: Update docs to reflect new development workflow.)

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Update .gitignore files.
  2014-12-08 18:13 ` [PATCH] Update .gitignore files Bryan Hundven
@ 2014-12-08 18:18   ` Bryan Hundven
  0 siblings, 0 replies; 2+ messages in thread
From: Bryan Hundven @ 2014-12-08 18:18 UTC (permalink / raw)
  To: James Byrne; +Cc: crossgcc maillist

James, list,

On Mon, Dec 8, 2014 at 10:13 AM, Bryan Hundven <bryanhundven@gmail.com> wrote:
> James,
>
> On Mon, Dec 8, 2014 at 9:50 AM, James Byrne
> <james.byrne@origamienergy.com> wrote:
>> The current .gitignore files cause changes to files which are actually part of
>> the repository to be ignored. This commit modifies the rules so that this does
>> not happen. The files that were affected are:
>>
>>   config/global/paths.in
>>   contrib/gcc-test-suite/Makefile
>>   docs/ct-ng.1.in
>>   kconfig/Makefile
>>
>> (as revealed by 'git ls-files --ignored --exclude-standard')
>>
>> Signed-off-by: James Byrne <james.byrne@origamienergy.com>
>> ---
>>  .gitignore      | 3 ++-
>>  docs/.gitignore | 1 +
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 90b516d..7854d8b 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -3,11 +3,12 @@ configure
>>  autom4te.cache
>>  config.log
>>  config.status
>> -Makefile
>> +/Makefile
>>  *ct-ng*
>>  !ct-ng.comp
>>  !ct-ng.in
>>  paths.*
>> +!paths.in
>>  config.gen/
>>  .config
>>  .config.2
>> diff --git a/docs/.gitignore b/docs/.gitignore
>> index 53f6ef9..fc05ff2 100644
>> --- a/docs/.gitignore
>> +++ b/docs/.gitignore
>> @@ -1,2 +1,3 @@
>>  *ct-ng*.1
>>  *ct-ng*.1.gz
>> +!ct-ng.1.in
>> --
>> 1.9.1
>>
>
> The patch does fix the files that should not be ignored.
> I'd prefer that new patches use github from now on:
>     https://github.com/crosstool-ng/crosstool-ng
>
>     https://help.github.com/articles/using-pull-requests/
>
> For one, patchwork is ran on a crontab, so your patch is not
> immediately available for me to apply from patchwork. Whereas if a
> pull request was opened on github, I'm able to test and apply as soon
> as possible.
>
> As of the time of sending this email, the patch is still not available
> on patchwork, and I will continue to watch patchwork and wait for it
> to be available so I can apply it.
>
> Please use github from now on. :)
>
> -Bryan
> (Note to self: Update docs to reflect new development workflow.)

Actually, I just noticed that your original email is not on the mailing list:
https://sourceware.org/ml/crossgcc/2014-12/

Did it bounce back to you?

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-08 18:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1418061040-3946-1-git-send-email-james.byrne@origamienergy.com>
2014-12-08 18:13 ` [PATCH] Update .gitignore files Bryan Hundven
2014-12-08 18:18   ` Bryan Hundven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).