From: Michael Hope <michael.hope@linaro.org>
To: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Cc: crossgcc@sourceware.org
Subject: Re: [PATCH] configure: support arbitrary versions via a shell script
Date: Tue, 15 Nov 2011 02:42:00 -0000 [thread overview]
Message-ID: <CANLjY-=325FUpW3_q55TdoGWr7fkBCGMf08YbjUYMZ5g_bxo-w@mail.gmail.com> (raw)
In-Reply-To: <201111142217.33054.yann.morin.1998@anciens.enib.fr>
On Tue, Nov 15, 2011 at 10:17 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Michael, All,
>
> On Monday 14 November 2011 21:37:15 Michael Hope wrote:
>> That sounds good. There's a minor bug in your version: ./configure
>> --help uses the version from .version instead of version.sh as
>> do_help() is called before version.sh is updated.
>>
>> Then again, it had a similar problem before the patch: ./configure
>> --help would report crosstool-NG-hg instead of the full
>> crosstool-NG-hg-revno-foo.
>
> Indeed, the /issue/ was there previously as well.
> So, it is not a regression! ;-)
>
>> Let me know if it's important and I can make a patch,
>
> I understand it could be confusing.
> - the easy way is to remove the version string from the help entry;
> - the proper way would be to move the version computation upward, but
> it needs ${sed} that is available only after the tests, which do not
> get run for --help.
>
> So, we could just move the version calculations upward, print the pristine
> version string in --help, and just mangle the string at the moment we need
> it and can do it.
>
> If the sight of the incorrect version string is absolutely untenable for
> you, if your screen turns itself off so you don't get to see it, if you
> lose your sanity at the mere thought of seeing the raw version, then by
> all means, send a patch! ;-)
The current version is fine,
-- Michael the nit-picker
--
For unsubscribe information see http://sourceware.org/lists.html#faq
prev parent reply other threads:[~2011-11-15 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 23:10 Michael Hope
2011-11-14 7:21 ` Yann E. MORIN
2011-11-14 20:37 ` Michael Hope
2011-11-14 21:17 ` Yann E. MORIN
2011-11-15 2:42 ` Michael Hope [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLjY-=325FUpW3_q55TdoGWr7fkBCGMf08YbjUYMZ5g_bxo-w@mail.gmail.com' \
--to=michael.hope@linaro.org \
--cc=crossgcc@sourceware.org \
--cc=yann.morin.1998@anciens.enib.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).