From: Michael Hope <michael.hope@linaro.org>
To: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
Cc: crossgcc@sourceware.org, Zhenqiang Chen <zhenqiang.chen@linaro.org>
Subject: Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS
Date: Wed, 23 Nov 2011 01:48:00 -0000 [thread overview]
Message-ID: <CANLjY-=MPbhNmQQO=srou9fGzdgOciT7EQAr=tXMWQgZS=Rm3A@mail.gmail.com> (raw)
In-Reply-To: <201111221821.22751.yann.morin.1998@anciens.enib.fr>
On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Zhenqiang, All,
>
> On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote:
>> # HG changeset patch
>> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
>> # Date 1321604572 -28800
>> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
>> # Parent a6c68712024f406df7d2da4af377f51982615833
>> debug/gdb: --disable-sim for CT_GDB_CROSS.
>>
>> sim was already disabled for CT_GDB_NATIVE.
>>
>> Reviewed-by: Michael Hope
>> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>
>> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.
>> --- a/scripts/build/debug/300-gdb.sh
>> +++ b/scripts/build/debug/300-gdb.sh
>> @@ -146,6 +146,7 @@
>> --with-build-sysroot="${CT_SYSROOT_DIR}" \
>> --with-sysroot="${CT_SYSROOT_DIR}" \
>> --with-expat=yes \
>> + --disable-sim \
>> --disable-werror \
>> "${cross_extra_config[@]}"
>
> Your mailer is mangling every patch, by adding a leading space to every
> line that start with a space, so the patches do not apply cleanly. I will
> be fixing that locally, no need to resend.
>
> Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the
> cross-gdb? If the build is broken for some archs, it should rather be
> fixed. At least, disabling/enabling 'sim' should be a config option,
> so users that want to try and/or fix it have an easy way to.
I'd like to disable sim as it isn't useful when building for a GLIBC
target and it's one more thing to support. ARM don't want to
distribute a binary simulator due to IP reasons which I must admit
I've never understood :)
How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead? Disabling the
simulator is rare enough that it shouldn't be an option on it's own.
-- Michael
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2011-11-23 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:20 Zhenqiang Chen
2011-11-22 15:29 ` Mike Frysinger
2011-11-22 17:21 ` Yann E. MORIN
2011-11-23 1:48 ` Michael Hope [this message]
2011-11-23 2:41 ` Khem Raj
2011-11-23 3:44 ` Zhenqiang Chen
2011-11-23 18:34 ` Mike Frysinger
2012-01-29 21:15 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLjY-=MPbhNmQQO=srou9fGzdgOciT7EQAr=tXMWQgZS=Rm3A@mail.gmail.com' \
--to=michael.hope@linaro.org \
--cc=crossgcc@sourceware.org \
--cc=yann.morin.1998@anciens.enib.fr \
--cc=zhenqiang.chen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).