From: Ray Donnelly <mingw.android@gmail.com>
To: Bryan Hundven <bryanhundven@gmail.com>
Cc: "crossgcc@sourceware.org" <crossgcc@sourceware.org>
Subject: Re: [PATCH 3/3] {e}glibc: Fix various multilib build bugs
Date: Tue, 04 Feb 2014 21:33:00 -0000 [thread overview]
Message-ID: <CAOYw7dvgBwX8ccW_xWZxK+6yCuAPLhEEGYwU7C7=V3oZdonQsQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ+oik3tNvEzg1mVd0TbtjSkY9t=-LEO0QssJ=KHO=-acLG8Cw@mail.gmail.com>
I'm not having the best time of it today! Bryan, I forgot to CC the ML
(so most of this you got already) but also, there's a dumb error in my
patch:
target = $(get_multilib_target "${extra_flags}")
needs to be changed to:
target=$(get_multilib_target "${extra_flags}")
On Tue, Feb 4, 2014 at 8:14 PM, Bryan Hundven <bryanhundven@gmail.com> wrote:
> Ray, Cody, list,
>
> On Tue, Feb 4, 2014 at 10:49 AM, Ray Donnelly <mingw.android@gmail.com> wrote:
>> Here is the new version using Cody's get_multilib_target () function.
>>
>> Cheers,
>>
>> Ray.
>
> I have some comments on this commit, but it's attached :(
> I recommend using the patchbomb method:
> http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/docs/C%20-%20Misc.%20tutorials.txt#l183
>
Sorry about the attachments, I've only submitted a few minor patches
so far and nothing that needed much discussion.
Is patchbomb easy to setup with gmail? If you can point me at some
instructions that'd be appreciated.
IMHO ctng should move to Git and use Gerrit (or failing that maybe
just github) for these code reviews, but I understand that this would
be quite a significant time drain to implement.
> Anyways, it seems to me that get_multilib_target should be stubbed in
> scripts/build/arch/multilib.sh, and implemented in the respective
> scripts/build/arch/<architecture>.sh
> Source multilib.sh after this line:
> http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/scripts/crosstool-NG.sh.in#l140
>
I agree we could move get_multilib_target somewhere more general
purpose, but I'd put it into multilib.sh and leave it at that.
Personally, I prefer having the full gory details available in (and
easily testable from) a single function rather than splitting it up.
> That way, any package - beyond (e)glibc - can obtain the multilib
> target info if needed.
>
> Other points are easier to discuss inline. Cody, Ray; what are your thoughts?
>
> -Bryan
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2014-02-04 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 18:49 Ray Donnelly
2014-02-04 20:14 ` Bryan Hundven
2014-02-04 21:33 ` Ray Donnelly [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-04 8:44 Ray Donnelly
2014-02-04 8:35 Ray Donnelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOYw7dvgBwX8ccW_xWZxK+6yCuAPLhEEGYwU7C7=V3oZdonQsQ@mail.gmail.com' \
--to=mingw.android@gmail.com \
--cc=bryanhundven@gmail.com \
--cc=crossgcc@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).