GREP_OPTION=--color=always breaks config

GREP_OPTION=--color=always breaks config

[Kevin Kirkup]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

When the GREP_OPTIONS is set to --color=always, the configure step
fails.

Steps to reproduce:
1) set the GREP_OPTIONS flag in bash
 $ export GREP_OPTIONS=--color=always
2) Run ct-ng config
 $ ct-ng menuconfig arm-unknown-linux-gnueabi
3) Build fails with the following error:

config.gen/arch.in:19: unknown option "01"
config.gen/arch.in:24: unknown option "01"
config.gen/arch.in:33: unknown option "01"
config.gen/arch.in:42: unknown option "01"
config.gen/libc.in:11: unknown option "01"
config.gen/libc.in:16: unknown option "01"
config.gen/libc.in:21: unknown option "01"
config.gen/libc.in:26: unknown option "01"

^[[01;31m^[[K# depends on ^[[m^[[KEXPERIMENTAL

4) Unset GREP_OPTIONS
 $ export GREP_OPTIONS=

5) Reconfigure
 $ ct-ng menuconfig arm-unknown-linux-gnueabi

6) Build works fine.

Any ideas?
--
Kevin S Kirkup
email: kevin.kirkup@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

Re: GREP_OPTION=--color=always breaks config

[Yann E. MORIN]

[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]

Kevin,
All,

On Monday 28 December 2009 05:12:48 Kevin Kirkup wrote:
> When the GREP_OPTIONS is set to --color=always, the configure step
> fails.

Woopss...

> Steps to reproduce:
> 1) set the GREP_OPTIONS flag in bash
>  $ export GREP_OPTIONS=--color=always
> 2) Run ct-ng config
>  $ ct-ng menuconfig arm-unknown-linux-gnueabi
> 3) Build fails with the following error:
> config.gen/arch.in:19: unknown option "01"
[--SNIP--]
> Any ideas?

Can you try the attached patch, please ?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'

[-- Attachment #2: ct-ng-grep-options.patch --]
[-- Type: text/x-diff, Size: 1378 bytes --]

diff --git a/config/config.mk b/config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -88,7 +88,7 @@
 	    echo "config $(3)_$${_entry}";                                      \
 	    echo "    bool";                                                    \
 	    echo "    prompt \"$${entry}\"";                                    \
-	    dep_val=$$($(grep) -E '^# depends on ' $${file} 2>/dev/null);       \
+	    dep_val=$$(GREP_OPTIONS= $(grep) -E '^# depends on ' $${file} 2>/dev/null);       \
 	    if [ -n "$${dep_val}" ]; then                                       \
 	      echo "    $${dep_val#\# }";                                       \
 	    fi;                                                                 \
@@ -133,7 +133,7 @@
 	    echo "menuconfig $(3)_$${_entry}";                                  \
 	    echo "    bool";                                                    \
 	    echo "    prompt \"$${entry}\"";                                    \
-	    dep_val=$$($(grep) -E '^# depends on ' $${file} 2>/dev/null);       \
+	    dep_val=$$(GREP_OPTIONS= $(grep) -E '^# depends on ' $${file} 2>/dev/null);       \
 	    if [ -n "$${dep_val}" ]; then                                       \
 	      echo "    $${dep_val#\# }";                                       \
 	    fi;                                                                 \


[-- Attachment #3: Type: text/plain, Size: 71 bytes --]

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: GREP_OPTION=--color=always breaks config

[Yann E. MORIN]

Kevin, All,

(Please, keep the list in CC: next time.)

On Monday 28 December 2009 20:01:59 Kevin Kirkup wrote:
> Yeah that fixed the problem.

OK. Thank you for the report. I will put a proper fix in place shortly.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: GREP_OPTION=--color=always breaks config

[Yann E. MORIN]

Kevin, All,

On Monday 28 December 2009 05:12:48 Kevin Kirkup wrote:
> When the GREP_OPTIONS is set to --color=always, the configure step
> fails.

Fixed as a5020a1facff. Thank you for the report!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: GREP_OPTION=--color=always breaks config

[Nicolas Alvarez]

Kevin Kirkup wrote:
> When the GREP_OPTIONS is set to --color=always, the configure step
> fails.

Isn't that quite a bad idea? ;) --color=auto is there for a reason.

-- 
Nicolas

(I read mailing lists through Gmane. Please don't Cc me on replies; it makes 
me get one message on my newsreader and another on email.)


--
For unsubscribe information see http://sourceware.org/lists.html#faq