public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* are curr: and test: no longer accepted in .hint files?
@ 2017-03-24 16:18 Andrew Schulman
  2017-03-24 16:36 ` Yaakov Selkowitz
  2017-03-24 17:34 ` Jon Turney
  0 siblings, 2 replies; 7+ messages in thread
From: Andrew Schulman @ 2017-03-24 16:18 UTC (permalink / raw)
  To: cygwin-apps

I tried adding

curr: 1.7.3.2-1
test: 2.0.0-b9-1

to the .hint files in my latest upload of socat. Those fields used to be
supported to indicate current and test versions, but this time I got this
back from calm:

ERROR: package 'socat': unknown key curr at line 10
ERROR: package 'socat': test has non-empty value '2.0.0-b9-1'
ERROR: errors while parsing hints for package 'socat'
ERROR: package 'socat-debuginfo': unknown key curr at line 6
ERROR: package 'socat-debuginfo': test has non-empty value '2.0.0-b9-1'
ERROR: errors while parsing hints for package 'socat-debuginfo'
ERROR: error while reading uploaded arch x86 packages from maintainer
Andrew Schulman
ERROR: package 'socat': unknown key curr at line 10
ERROR: package 'socat': test has non-empty value '2.0.0-b9-1'
ERROR: errors while parsing hints for package 'socat'
ERROR: package 'socat-debuginfo': unknown key curr at line 6
ERROR: package 'socat-debuginfo': test has non-empty value '2.0.0-b9-1'
ERROR: errors while parsing hints for package 'socat-debuginfo'
ERROR: error while reading uploaded arch x86_64 packages from maintainer
Andrew Schulman

What's the supported way now to tell calm which versions are previous,
current, and test when you need to override the defaults?

Thanks,
Andrew

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 16:18 are curr: and test: no longer accepted in .hint files? Andrew Schulman
@ 2017-03-24 16:36 ` Yaakov Selkowitz
  2017-03-24 16:44   ` Andrew Schulman
  2017-03-24 17:34 ` Jon Turney
  1 sibling, 1 reply; 7+ messages in thread
From: Yaakov Selkowitz @ 2017-03-24 16:36 UTC (permalink / raw)
  To: cygwin-apps

On 2017-03-24 11:18, Andrew Schulman wrote:
> I tried adding
>
> curr: 1.7.3.2-1
> test: 2.0.0-b9-1
              ^
Hyphens aren't allowed in versions, it messes up the sorting.  This 
needs to be VERSION=2.0.0; RELEASE=0.1.b9; then the next beta will be 
0.2.b10, etc., until 2.0.0 is final with RELEASE=1.

-- 
Yaakov

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 16:36 ` Yaakov Selkowitz
@ 2017-03-24 16:44   ` Andrew Schulman
  2017-03-24 17:42     ` Jon Turney
  0 siblings, 1 reply; 7+ messages in thread
From: Andrew Schulman @ 2017-03-24 16:44 UTC (permalink / raw)
  To: cygwin-apps

> On 2017-03-24 11:18, Andrew Schulman wrote:
> > I tried adding
> >
> > curr: 1.7.3.2-1
> > test: 2.0.0-b9-1
>               ^
> Hyphens aren't allowed in versions, it messes up the sorting.  This 
> needs to be VERSION=2.0.0; RELEASE=0.1.b9; then the next beta will be 
> 0.2.b10, etc., until 2.0.0 is final with RELEASE=1.

OK, I'll do that. But why does calm say

ERROR: package 'socat': unknown key curr at line 10

?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 16:18 are curr: and test: no longer accepted in .hint files? Andrew Schulman
  2017-03-24 16:36 ` Yaakov Selkowitz
@ 2017-03-24 17:34 ` Jon Turney
  2017-03-24 17:41   ` Andrew Schulman
  1 sibling, 1 reply; 7+ messages in thread
From: Jon Turney @ 2017-03-24 17:34 UTC (permalink / raw)
  To: cygwin-apps; +Cc: Schulman, Andrew

On 24/03/2017 16:18, Andrew Schulman wrote:
> I tried adding
>
> curr: 1.7.3.2-1
> test: 2.0.0-b9-1
>
> to the .hint files in my latest upload of socat. Those fields used to be
> supported to indicate current and test versions, but this time I got this
> back from calm:
>
> ERROR: package 'socat': unknown key curr at line 10
> ERROR: package 'socat': test has non-empty value '2.0.0-b9-1'
> ERROR: errors while parsing hints for package 'socat'
> ERROR: package 'socat-debuginfo': unknown key curr at line 6
> ERROR: package 'socat-debuginfo': test has non-empty value '2.0.0-b9-1'
> ERROR: errors while parsing hints for package 'socat-debuginfo'
> ERROR: error while reading uploaded arch x86 packages from maintainer
> Andrew Schulman
> ERROR: package 'socat': unknown key curr at line 10
> ERROR: package 'socat': test has non-empty value '2.0.0-b9-1'
> ERROR: errors while parsing hints for package 'socat'
> ERROR: package 'socat-debuginfo': unknown key curr at line 6
> ERROR: package 'socat-debuginfo': test has non-empty value '2.0.0-b9-1'
> ERROR: errors while parsing hints for package 'socat-debuginfo'
> ERROR: error while reading uploaded arch x86_64 packages from maintainer
> Andrew Schulman
>
> What's the supported way now to tell calm which versions are previous,
> current, and test when you need to override the defaults?

I'm assuming you have a recent cygport, which is now generating 
<pvr>.hint rather than setup.hint files.

It's not helpful to mention specific versions in a <pvr>.hint files, so 
curr: is not permitted, and test: is not permitted to specify a version

If you need to override the default version ordering, then a separate 
per-package override.hint [1] can be used.

In this case, I think all you want to do is continue to mark 2.0.0-b9-1 
as a 'test' version.  As discussed in [2], the current thinking is that 
should be achieved with a 'test:' label in the associated pvr.hint, but 
unfortunately, this package pre-dates the pvr.hint changes, so you'll 
have to use override.hint

[1] https://cygwin.com/packaging-hint-files.html#override.hint
[2] https://cygwin.com/ml/cygwin-apps/2016-12/msg00005.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 17:34 ` Jon Turney
@ 2017-03-24 17:41   ` Andrew Schulman
  2017-03-24 17:54     ` Andrew Schulman
  0 siblings, 1 reply; 7+ messages in thread
From: Andrew Schulman @ 2017-03-24 17:41 UTC (permalink / raw)
  To: cygwin-apps

> > What's the supported way now to tell calm which versions are previous,
> > current, and test when you need to override the defaults?
> 
> I'm assuming you have a recent cygport, which is now generating 
> <pvr>.hint rather than setup.hint files.
> 
> It's not helpful to mention specific versions in a <pvr>.hint files, so 
> curr: is not permitted, and test: is not permitted to specify a version
> 
> If you need to override the default version ordering, then a separate 
> per-package override.hint [1] can be used.
> 
> In this case, I think all you want to do is continue to mark 2.0.0-b9-1 
> as a 'test' version.  As discussed in [2], the current thinking is that 
> should be achieved with a 'test:' label in the associated pvr.hint, but 
> unfortunately, this package pre-dates the pvr.hint changes, so you'll 
> have to use override.hint
> 
> [1] https://cygwin.com/packaging-hint-files.html#override.hint
> [2] https://cygwin.com/ml/cygwin-apps/2016-12/msg00005.html

Thanks. I hadn't seen [1] yet. I'll rework the hint files.

Thanks to whoever overhauled the package maintainer's guide in the last
year or two. The last time I looked at it, it was badly out of date. What's
there now is good.

Andrew

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 16:44   ` Andrew Schulman
@ 2017-03-24 17:42     ` Jon Turney
  0 siblings, 0 replies; 7+ messages in thread
From: Jon Turney @ 2017-03-24 17:42 UTC (permalink / raw)
  To: cygwin-apps

On 24/03/2017 16:44, Andrew Schulman wrote:
>> On 2017-03-24 11:18, Andrew Schulman wrote:
>>> I tried adding
>>>
>>> curr: 1.7.3.2-1
>>> test: 2.0.0-b9-1
>>               ^
>> Hyphens aren't allowed in versions, it messes up the sorting.  This

Certainly they may not sort the way you expect :)

Another reason for disallowing this is that it makes decomposing a 
package name into P-V-R ambiguous

Going forward, I think we want to add this to the rules for hyphenation 
in [1]

>> needs to be VERSION=2.0.0; RELEASE=0.1.b9; then the next beta will be
>> 0.2.b10, etc., until 2.0.0 is final with RELEASE=1.

Actually, since this is an existing package, it has a grandfathered-in 
exception to this rule, but it would be nice to bear this in mind for 
the future.

[1] https://cygwin.com/packaging-package-files.html#naming

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: are curr: and test: no longer accepted in .hint files?
  2017-03-24 17:41   ` Andrew Schulman
@ 2017-03-24 17:54     ` Andrew Schulman
  0 siblings, 0 replies; 7+ messages in thread
From: Andrew Schulman @ 2017-03-24 17:54 UTC (permalink / raw)
  To: cygwin-apps

> > > What's the supported way now to tell calm which versions are previous,
> > > current, and test when you need to override the defaults?
> > 
> > I'm assuming you have a recent cygport, which is now generating 
> > <pvr>.hint rather than setup.hint files.
> > 
> > It's not helpful to mention specific versions in a <pvr>.hint files, so 
> > curr: is not permitted, and test: is not permitted to specify a version
> > 
> > If you need to override the default version ordering, then a separate 
> > per-package override.hint [1] can be used.
> > 
> > In this case, I think all you want to do is continue to mark 2.0.0-b9-1 
> > as a 'test' version.  As discussed in [2], the current thinking is that 
> > should be achieved with a 'test:' label in the associated pvr.hint, but 
> > unfortunately, this package pre-dates the pvr.hint changes, so you'll 
> > have to use override.hint
> > 
> > [1] https://cygwin.com/packaging-hint-files.html#override.hint
> > [2] https://cygwin.com/ml/cygwin-apps/2016-12/msg00005.html
> 
> Thanks. I hadn't seen [1] yet. I'll rework the hint files.
> 
> Thanks to whoever overhauled the package maintainer's guide in the last
> year or two. The last time I looked at it, it was badly out of date. What's
> there now is good.

Hm, looking in the git log, I see it was YOU. Now abusing my authority as
Gold Star page maintainer:

Gold star awarded! https://cygwin.com/goldstars/#JTy

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-03-24 17:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 16:18 are curr: and test: no longer accepted in .hint files? Andrew Schulman
2017-03-24 16:36 ` Yaakov Selkowitz
2017-03-24 16:44   ` Andrew Schulman
2017-03-24 17:42     ` Jon Turney
2017-03-24 17:34 ` Jon Turney
2017-03-24 17:41   ` Andrew Schulman
2017-03-24 17:54     ` Andrew Schulman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).