public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* [PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script
@ 2024-02-23 12:09 Christian Franke
  2024-03-10 17:20 ` Jon Turney
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Franke @ 2024-02-23 12:09 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 42 bytes --]

Harmless bug ...

-- 
Regards,
Christian


[-- Attachment #2: 0001-Fix-variable-expansion-in-error-message-of-embedded-.patch --]
[-- Type: text/plain, Size: 874 bytes --]

From b1074f4cfe549c852be7fa59d85d312c9579cf0d Mon Sep 17 00:00:00 2001
From: Christian Franke <christian.franke@t-online.de>
Date: Fri, 23 Feb 2024 13:04:21 +0100
Subject: [PATCH] Fix variable expansion in error message of embedded SMTP perl
 script

---
 lib/pkg_upload.cygpart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/pkg_upload.cygpart b/lib/pkg_upload.cygpart
index dcae8e2c..cdeae283 100644
--- a/lib/pkg_upload.cygpart
+++ b/lib/pkg_upload.cygpart
@@ -222,7 +222,7 @@ if (\$smtp_encryption eq 'tls') {
 	require Net::SMTP::SSL;
 	\$smtp->command('STARTTLS');
 	\$smtp->response();
-	\$smtp->code == 220 or die "$server does not support STARTTLS";
+	\$smtp->code == 220 or die "\$smtp_server does not support STARTTLS";
 	\$smtp = Net::SMTP::SSL->start_SSL(\$smtp) or die "STARTTLS failed";
 	\$smtp->hello(\$smtp_server);
 }
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script
  2024-02-23 12:09 [PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script Christian Franke
@ 2024-03-10 17:20 ` Jon Turney
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Turney @ 2024-03-10 17:20 UTC (permalink / raw)
  To: Christian Franke; +Cc: cygwin-apps

On 23/02/2024 12:09, Christian Franke via Cygwin-apps wrote:
> Harmless bug ...
> 

Applied. Thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-10 17:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 12:09 [PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script Christian Franke
2024-03-10 17:20 ` Jon Turney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).