public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Takashi Yano <takashi.yano@nifty.ne.jp>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITA] (was [ITP] fdk-aac-free (2.0.0))
Date: Thu, 16 Feb 2023 18:49:10 +0000	[thread overview]
Message-ID: <11799ce9-2de8-5ec1-2ce0-337e4b297311@dronecode.org.uk> (raw)
In-Reply-To: <20230214181100.9fa28f76580c404f5883413b@nifty.ne.jp>

On 14/02/2023 09:11, Takashi Yano via Cygwin-apps wrote:
> On Mon, 13 Feb 2023 18:02:11 +0000
> Jon Turney wrote:
>> On 13/02/2023 10:43, Takashi Yano via Cygwin-apps wrote:
>>> CYGCONF_ARGS="--disable-silent-rules --disable-static"
>>
>> Is '--disable-silent-rules' necessary to build successfully?  Otherwise,
>> I don't see why it might be here.
> 
> The original (Yaakov's) package did not specify these
> config flags. So, I have removed them.
> 

Looks good.

Generally, we expect packages to produce shared libraries only (unless 
there's a good reason to do otherwise) (in this case, the autotools 
cygclass should be already arranging for that to happen).

The point should probably be touched on in the cygport manual and/or 
packing guidelines.


      reply	other threads:[~2023-02-16 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-05  8:38 [ITP] fdk-aac-free (2.0.0) Takashi Yano
2023-02-05 16:34 ` Jon Turney
2023-02-06 12:21   ` Takashi Yano
2023-02-13 10:43     ` [ITA] (was [ITP] fdk-aac-free (2.0.0)) Takashi Yano
2023-02-13 18:02       ` Jon Turney
2023-02-14  9:11         ` Takashi Yano
2023-02-16 18:49           ` Jon Turney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11799ce9-2de8-5ec1-2ce0-337e4b297311@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).