[ITP] fdk-aac-free (2.0.0)

[ITP] fdk-aac-free (2.0.0)

[Takashi Yano]

I would like to propose new package fdk-aac-free, which is
a AAC audio codec library. This is a free version of FDK-AAD,
and is needed by ffmpeg package I had proposed. This is also
provided for ffmpeg-free package in fedora.

I already prepared the package at the following location.

https://tyan0.yr32.net/cygwin/x86_64/release/fdk-aac-free/

--
Takashi Yano <takashi.yano@nifty.ne.jp>

Re: [ITP] fdk-aac-free (2.0.0)

[Jon Turney]

On 05/02/2023 08:38, Takashi Yano via Cygwin-apps wrote:
> I would like to propose new package fdk-aac-free, which is
> a AAC audio codec library. This is a free version of FDK-AAD,
> and is needed by ffmpeg package I had proposed. This is also
> provided for ffmpeg-free package in fedora.
> 
> I already prepared the package at the following location.
> 
> https://tyan0.yr32.net/cygwin/x86_64/release/fdk-aac-free/

It looks like perhaps the shared library package should be called 
'libfdk-aac2' as the library has a soversion.

Otherwise, this looks ok.

Re: [ITP] fdk-aac-free (2.0.0)

[Takashi Yano]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Sun, 5 Feb 2023 16:34:41 +0000
Jon Turney wrote:
> On 05/02/2023 08:38, Takashi Yano via Cygwin-apps wrote:
> > I would like to propose new package fdk-aac-free, which is
> > a AAC audio codec library. This is a free version of FDK-AAD,
> > and is needed by ffmpeg package I had proposed. This is also
> > provided for ffmpeg-free package in fedora.
> > 
> > I already prepared the package at the following location.
> > 
> > https://tyan0.yr32.net/cygwin/x86_64/release/fdk-aac-free/
> 
> It looks like perhaps the shared library package should be called 
> 'libfdk-aac2' as the library has a soversion.
> 
> Otherwise, this looks ok.

Thanks for the advice. I revised the cygport file
as attached. Is this as you expected?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

[-- Attachment #2: fdk-aac.cygport --]
[-- Type: text/plain, Size: 906 bytes --]

NAME="fdk-aac-free"
VERSION=2.0.0
RELEASE=1
CATEGORY="Audio"
SUMMARY="Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android"
DESCRIPTION="The Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android is software that implements part of the MPEG Advanced Audio Coding (AAC) encoding and decoding scheme for digital audio."
HOMEPAGE="https://cgit.freedesktop.org/~wtay/fdk-aac/log/?h=fedora"
LICENSE="FDK-AAC"
SRC_URI="https://people.freedesktop.org/~wtay/fdk-aac-free-${VERSION}.tar.gz"
PKG_NAMES="libfdk-aac2 libfdk-aac-devel"
CYGCONF_ARGS="--disable-silent-rules --disable-static"
libfdk_aac2_CATEGORY="Audio Libs"
libfdk_aac2_SUMMARY="fdk-aac-free runtime library"
libfdk_aac2_CONTENTS="usr/bin usr/share"
libfdk_aac_devel_CATEGORY="Audio Devel"
libfdk_aac_devel_SUMMARY="fdk-aac-free development package"
libfdk_aac_devel_CONTENTS="usr/include usr/lib"

[ITA] (was [ITP] fdk-aac-free (2.0.0))

[Takashi Yano]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On Mon, 6 Feb 2023 21:21:49 +0900
Takashi Yano wrote:
> On Sun, 5 Feb 2023 16:34:41 +0000
> Jon Turney wrote:
> > On 05/02/2023 08:38, Takashi Yano via Cygwin-apps wrote:
> > > I would like to propose new package fdk-aac-free, which is
> > > a AAC audio codec library. This is a free version of FDK-AAD,
> > > and is needed by ffmpeg package I had proposed. This is also
> > > provided for ffmpeg-free package in fedora.
> > > 
> > > I already prepared the package at the following location.
> > > 
> > > https://tyan0.yr32.net/cygwin/x86_64/release/fdk-aac-free/
> > 
> > It looks like perhaps the shared library package should be called 
> > 'libfdk-aac2' as the library has a soversion.
> > 
> > Otherwise, this looks ok.
> 
> Thanks for the advice. I revised the cygport file
> as attached. Is this as you expected?

Sorry, this should be ITA rather than ITP because the package
fdk-aac already exists in package list. The package name has
been followed to the existing package.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

[-- Attachment #2: fdk-aac.cygport --]
[-- Type: text/plain, Size: 901 bytes --]

NAME="fdk-aac"
VERSION=2.0.0
RELEASE=1
CATEGORY="Audio"
SUMMARY="Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android"
DESCRIPTION="The Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android is software that implements part of the MPEG Advanced Audio Coding (AAC) encoding and decoding scheme for digital audio."
HOMEPAGE="https://cgit.freedesktop.org/~wtay/fdk-aac/log/?h=fedora"
LICENSE="FDK-AAC"
SRC_URI="https://people.freedesktop.org/~wtay/fdk-aac-free-${VERSION}.tar.gz"
PKG_NAMES="libfdk-aac2 libfdk-aac-devel"
CYGCONF_ARGS="--disable-silent-rules --disable-static"
libfdk_aac2_CATEGORY="Audio Libs"
libfdk_aac2_SUMMARY="fdk-aac-free runtime library"
libfdk_aac2_CONTENTS="usr/bin usr/share"
libfdk_aac_devel_CATEGORY="Audio Devel"
libfdk_aac_devel_SUMMARY="fdk-aac-free development package"
libfdk_aac_devel_CONTENTS="usr/include usr/lib"

Re: [ITA] (was [ITP] fdk-aac-free (2.0.0))

[Jon Turney]

On 13/02/2023 10:43, Takashi Yano via Cygwin-apps wrote:
> CYGCONF_ARGS="--disable-silent-rules --disable-static"

Is '--disable-silent-rules' necessary to build successfully?  Otherwise, 
I don't see why it might be here.

Approved.

Re: [ITA] (was [ITP] fdk-aac-free (2.0.0))

[Takashi Yano]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

On Mon, 13 Feb 2023 18:02:11 +0000
Jon Turney wrote:
> On 13/02/2023 10:43, Takashi Yano via Cygwin-apps wrote:
> > CYGCONF_ARGS="--disable-silent-rules --disable-static"
> 
> Is '--disable-silent-rules' necessary to build successfully?  Otherwise, 
> I don't see why it might be here.

The original (Yaakov's) package did not specify these
config flags. So, I have removed them.

Thanks.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

[-- Attachment #2: fdk-aac.cygport --]
[-- Type: text/plain, Size: 880 bytes --]

NAME="fdk-aac"
VERSION=2.0.0
RELEASE=1
CATEGORY="Audio"
SUMMARY="Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android"
DESCRIPTION="The Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android is software that implements part of the MPEG Advanced Audio Coding (AAC) encoding and decoding scheme for digital audio."
HOMEPAGE="https://cgit.freedesktop.org/~wtay/fdk-aac/log/?h=fedora"
LICENSE="FDK-AAC"
SRC_URI="https://people.freedesktop.org/~wtay/fdk-aac-free-${VERSION}.tar.gz"
SRC_DIR="${NAME}-free-${VERSION}"
PKG_NAMES="libfdk-aac2 libfdk-aac-devel"
libfdk_aac2_CATEGORY="Audio Libs"
libfdk_aac2_SUMMARY="fdk-aac-free runtime library"
libfdk_aac2_CONTENTS="usr/bin usr/share"
libfdk_aac_devel_CATEGORY="Audio Devel"
libfdk_aac_devel_SUMMARY="fdk-aac-free development package"
libfdk_aac_devel_CONTENTS="usr/include usr/lib"

Re: [ITA] (was [ITP] fdk-aac-free (2.0.0))

[Jon Turney]

On 14/02/2023 09:11, Takashi Yano via Cygwin-apps wrote:
> On Mon, 13 Feb 2023 18:02:11 +0000
> Jon Turney wrote:
>> On 13/02/2023 10:43, Takashi Yano via Cygwin-apps wrote:
>>> CYGCONF_ARGS="--disable-silent-rules --disable-static"
>>
>> Is '--disable-silent-rules' necessary to build successfully?  Otherwise,
>> I don't see why it might be here.
> 
> The original (Yaakov's) package did not specify these
> config flags. So, I have removed them.
> 

Looks good.

Generally, we expect packages to produce shared libraries only (unless 
there's a good reason to do otherwise) (in this case, the autotools 
cygclass should be already arranging for that to happen).

The point should probably be touched on in the cygport manual and/or 
packing guidelines.