cygport package has one dependency missing

cygport package has one dependency missing

[Marcos Vives Del Sol]

File "/usr/share/cygport/cygclass/autotools.cygclass" requires
"autopoint", which is part of "gettext-devel" package but it isn't
specified in the setup.hint, and therefore it doesn't get installed
when selecting "cygport".

I saw an error complaining about "missing autopoint", but I thought
the error was controlled. Apparently it wasn't. The output of
autopoint was used as parameters of "grep", and therefore with no
parameters effectively it was running grep on stdin instead.

I stood still looking at a black screen for around twenty minutes till
I noticed what was going on.

PS: I am not sure if this is the correct mailing list. IMHO it is
since it's not a package bug but a misconfigured setup.hint which is
part of the packaging.

-- 
Marcos Vives Del Sol
https://github.com/socram8888
miniLock: NscWdW8fh2E5SBoRtrnXWrDwmQmwaR5awMKE78tQW1Ffx

Re: cygport package has one dependency missing

[Yaakov Selkowitz]

On Tue, 2015-02-24 at 10:55 +0100, Marcos Vives Del Sol wrote:
> File "/usr/share/cygport/cygclass/autotools.cygclass" requires
> "autopoint", which is part of "gettext-devel" package but it isn't
> specified in the setup.hint, and therefore it doesn't get installed
> when selecting "cygport".

If you are building a package with NLS, even manually, you need
gettext-devel installed for msgfmt and friends.  Therefore, this is
technically not a requirement of cygport but a build requirement of your
package, just like any other lib*-devel packages that you need to build
your package.

--
Yaakov

Re: cygport package has one dependency missing

[Jon TURNEY]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

On 27/02/2015 06:24, Yaakov Selkowitz wrote:
> On Tue, 2015-02-24 at 10:55 +0100, Marcos Vives Del Sol wrote:
>> File "/usr/share/cygport/cygclass/autotools.cygclass" requires
>> "autopoint", which is part of "gettext-devel" package but it isn't
>> specified in the setup.hint, and therefore it doesn't get installed
>> when selecting "cygport".
>
> If you are building a package with NLS, even manually, you need
> gettext-devel installed for msgfmt and friends.  Therefore, this is
> technically not a requirement of cygport but a build requirement of your
> package, just like any other lib*-devel packages that you need to build
> your package.

I feel this could be handled better, though.  Patch attached.



[-- Attachment #2: 0001-autotools-Avoid-grepping-stdin-if-autopoint-is-not-p.patch --]
[-- Type: text/plain, Size: 973 bytes --]

From f068b6ef468331654442a71d28b29d562a0ef619 Mon Sep 17 00:00:00 2001
From: Jon TURNEY <jon.turney@dronecode.org.uk>
Date: Fri, 27 Feb 2015 20:23:30 +0000
Subject: [PATCH] autotools: Avoid grepping stdin if autopoint is not present
 on PATH

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
 cygclass/autotools.cygclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cygclass/autotools.cygclass b/cygclass/autotools.cygclass
index 301bdd3..ac4e467 100644
--- a/cygclass/autotools.cygclass
+++ b/cygclass/autotools.cygclass
@@ -484,7 +484,7 @@ cygautoreconf() {
 
 		# libtool 2.2+ is incompatible with gettext before 0.17
 		# config.rpath is broken wrt dynamic linkage before 0.17
-		eval gettext_$(grep ^version= $(which ${AUTOPOINT}))
+		eval gettext_$(grep ^version= $(which ${AUTOPOINT} || echo /dev/null))
 		if ! __version_at_least 0.17 ${gettext_version}
 		then
 			error "cygautoreconf: at least gettext 0.17 required"
-- 
2.1.4