setup: Fix for file names containing colons

setup: Fix for file names containing colons

[Ken Brown]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

In case this got lost in the thread about font reorganization, I'm 
attaching the patch I proposed in

   https://cygwin.com/ml/cygwin/2015-09/msg00223.html

Ken

[-- Attachment #2: 0001-Fix-creation-of-parent-directory-for-file-names-cont.patch --]
[-- Type: text/plain, Size: 659 bytes --]

From 6d8d74bcca48f3b5ce31e6cf9121eb204adb37a8 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Fri, 25 Sep 2015 10:18:31 -0400
Subject: [PATCH] Fix creation of parent directory for file names containing
 colons

* mkdir.cc (mkdir_p): Remove special treatment of colon in path
name.
---
 mkdir.cc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mkdir.cc b/mkdir.cc
index dabc256..84bb176 100644
--- a/mkdir.cc
+++ b/mkdir.cc
@@ -98,8 +98,6 @@ mkdir_p (int isadir, const char *in_path, mode_t mode)
 
   for (c = path; *c; c++)
     {
-      if (*c == ':')
-	slash = 0;
       if (*c == '/' || *c == '\\')
 	slash = c;
     }
-- 
2.5.3

Re: setup: Fix for file names containing colons

[Jon Turney]

On 25/09/2015 15:27, Ken Brown wrote:
> In case this got lost in the thread about font reorganization, I'm
> attaching the patch I proposed in
>
>    https://cygwin.com/ml/cygwin/2015-09/msg00223.html

Ken,

Thanks very much for this patch.  I think it is correct.

This issue didn't show up in my testing as I have the terminus-fonts 
package installed, which explicitly creates the /etc/X11/fontpath.d 
directory.

Re: setup: Fix for file names containing colons

[Yaakov Selkowitz]

On Fri, 2015-09-25 at 10:27 -0400, Ken Brown wrote:
> In case this got lost in the thread about font reorganization, I'm 
> attaching the patch I proposed in
> 
>    https://cygwin.com/ml/cygwin/2015-09/msg00223.html

Thanks, pushed to master.  I'm working on a new version of setup now.

--
Yaakov