From: Jon Turney <jon.turney@dronecode.org.uk>
To: brian Inglis <Brian.Inglis@SystematicSw.ab.ca>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITA] fortune-mod - please review
Date: Sun, 11 Apr 2021 16:16:15 +0100 [thread overview]
Message-ID: <1e2133e8-d234-508f-5cc2-221ae8a3487c@dronecode.org.uk> (raw)
In-Reply-To: <ebb86bda-5e0d-02f2-9b2d-91638e7bcffa@SystematicSw.ab.ca>
On 09/04/2021 17:49, Brian Inglis wrote:
> Please review:
>
> - build now uses cmake
> - build requires unpackaged cpan module, installing with cpan in .cygport
> - x86 will not build with ninja, only if deinstalled
> - x86 applies but also regenerates source patches
Can you be a bit more explicit what the issues are on x86?
> See Google Drive for review files:
> https://drive.google.com/drive/folders/15500wdTKygcwVNB7-0XN9P6kd9pvByxJ
For future reference, giving a link to the cygport, rather than having
to dig it out of the source package would ease review.
> DEPEND="cmake ninja perl"
> BUILD_REQUIRES="$DEPEND"
build requires also seem to include Perl-Path-Tiny.
> cpan App::XML::DocBook::Builder
This is less than ideal, as this means this gets executed as a side
effect any time the cygport is sourced (e.g. if you run 'cygport
fortune-mod.cygport info').
If you really can't get this packaged, maybe it should be in the
src_compile instead?
Apart from that, looks good.
next prev parent reply other threads:[~2021-04-11 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 16:49 Brian Inglis
2021-04-11 15:16 ` Jon Turney [this message]
2021-04-11 18:47 ` Brian Inglis
2021-04-11 19:44 ` Achim Gratz
2021-04-12 0:00 ` Brian Inglis
2021-04-12 5:52 ` ASSI
2021-06-01 5:36 ` [ITP] perl-App-XML-DocBook-Builder [ITA] fortune-mod Brian Inglis
2021-06-01 17:39 ` Marco Atzeri
2021-06-05 15:40 ` Achim Gratz
2021-06-05 16:19 ` Marco Atzeri
2021-06-05 21:43 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e2133e8-d234-508f-5cc2-221ae8a3487c@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Brian.Inglis@SystematicSw.ab.ca \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).