public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: [PATCH setup 0/2] Improve behavior after download error
Date: Mon, 06 Nov 2017 21:49:00 -0000	[thread overview]
Message-ID: <20171106214907.7120-1-kbrown@cornell.edu> (raw)

This is a followup to
https://sourceware.org/ml/cygwin-apps/2017-11/msg00003.html.  The
focus of that thread was a crash that occurs on the topic/libsolv
branch.  Here I'm more interested in a UI issue.  Namely, I don't
think it's reasonable that setup goes back to the site page if the
user clicks Yes in response to "Download Incomplete. Try again?".
This is not what the message says will happen, and I'm not convinced
that it even works right if the user changes mirrors after being sent
to the site page.

The first patch in this series instead puts the relevant code in a
retry loop.  This should require indentation of a large amount of
code.  To keep the patch readable, I've saved the indentation for a
separate patch.

Ken Brown (2):
  Improve behavior after download error
  Whitespace fixes

 download.cc | 161 ++++++++++++++++++++++++++++++++----------------------------
 res.rc      |   1 +
 resource.h  |   1 +
 3 files changed, 88 insertions(+), 75 deletions(-)

-- 
2.15.0

             reply	other threads:[~2017-11-06 21:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 21:49 Ken Brown [this message]
2017-11-06 21:49 ` [PATCH setup 2/2] Whitespace fixes Ken Brown
2017-11-06 21:49 ` [PATCH setup 1/2] Improve behavior after download error Ken Brown
2017-11-07  4:28 ` [PATCH setup 0/2] " Brian Inglis
2017-11-07 18:56   ` Jon Turney
2017-11-08 14:35     ` Ken Brown
2017-11-08 18:52       ` Brian Inglis
2017-11-09 13:21         ` Jon Turney
2017-11-09 16:42           ` Ken Brown
2017-11-10 14:41             ` Ken Brown
2017-11-08 18:46     ` Brian Inglis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171106214907.7120-1-kbrown@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).