Re: [PATCH setup 0/2] Improve behavior after download error

[Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>]

On 2017-11-08 07:35, Ken Brown wrote:
> On 11/7/2017 1:56 PM, Jon Turney wrote:
>> On 07/11/2017 04:28, Brian Inglis wrote:
>>> On 2017-11-06 14:49, Ken Brown wrote:
>>>> This is a followup to
>>>> https://sourceware.org/ml/cygwin-apps/2017-11/msg00003.html.  The
>>>> focus of that thread was a crash that occurs on the topic/libsolv
>>>> branch.  Here I'm more interested in a UI issue.  Namely, I don't
>>>> think it's reasonable that setup goes back to the site page if the
>>>> user clicks Yes in response to "Download Incomplete. Try again?".
>>>> This is not what the message says will happen, and I'm not convinced
>>>> that it even works right if the user changes mirrors after being sent
>>>> to the site page.
>>>
>>> Would it make more sense to drop to the package chooser page, after issuing the
>>> error message and advising the user to: select Back to go to the package chooser
>>> page, select Next to retry the downloads, or select Cancel to exit?
>>
>> Do we actually report the package name for the failed download so that the
>> user could make an informed change in the package chooser?
> 
> No.  Currently the only way for the user to find out is to finish the setup run
> and then look at the log.  There's been a FIXME about this at the end of
> download.cc:download_one() since 2001.  Maybe it's time to fix this.  We could
> simply keep a list of packages (or files?) for which the download failed, and
> then report this in the "Download incomplete" dialog.

An approach I've used in various apps which generate logs or other output files
which contain a status report on errors, is to launch the txt, html, xls, etc.
using the default user app, as with cygstart.
Whether you should do that in (semi-)unattended mode is your design decision.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada