From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: [PATCH setup 0/5] Improve behavior after download error, v2
Date: Fri, 10 Nov 2017 14:43:00 -0000 [thread overview]
Message-ID: <20171110144339.12616-1-kbrown@cornell.edu> (raw)
Currently setup goes back to the mirror selection page after a
download error if the user answers "Yes" to "Download incomplete. Try
again?". The same happens in unattended mode until the retries have
been exhausted.
And if the user answers "No", then installation continues, even though
this can damage the user's installation. For example, if a package is
selected for reinstall but cannot be downloaded, it will be
uninstalled.
This series of patches changes the behavior as follows:
- In unattended mode, simply retry the download.
- In interactive mode, pop up a dialog showing which packages had
download errors and giving the user the following options:
- Retry (retries download)
- Back (return to the package selection page)
- Continue, with a warning
- Cancel (exit)
Ken Brown (5):
Just retry download after error in unattended mode
Fix off-by-one error in download retry report
Remove "Try again?" from exit message.
Query user after download error in interactive mode
Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox
download.cc | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++---------
res.rc | 23 ++++++++++++++
resource.h | 3 ++
3 files changed, 111 insertions(+), 14 deletions(-)
--
2.15.0
next reply other threads:[~2017-11-10 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 14:43 Ken Brown [this message]
2017-11-10 14:43 ` [PATCH setup 1/5] Just retry download after error in unattended mode Ken Brown
2017-11-10 14:43 ` [PATCH setup 2/5] Fix off-by-one error in download retry report Ken Brown
2017-11-10 14:43 ` [PATCH setup 3/5] Remove "Try again?" from exit message Ken Brown
2017-11-10 14:43 ` [PATCH setup 5/5] Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox Ken Brown
2017-11-10 14:43 ` [PATCH setup 4/5] Query user after download error in interactive mode Ken Brown
2017-11-13 11:51 ` [PATCH setup 0/5] Improve behavior after download error, v2 Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110144339.12616-1-kbrown@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).