* [PATCH cygport] Raise an error if we package a .stackdump file
@ 2018-07-13 16:16 Jon Turney
2020-03-24 3:07 ` Yaakov Selkowitz
0 siblings, 1 reply; 2+ messages in thread
From: Jon Turney @ 2018-07-13 16:16 UTC (permalink / raw)
To: cygwin-apps; +Cc: Jon Turney
If we end up with a .stackdump file in a package, this tends to suggest
something has gone wrong somewhere, so raise an error.
---
lib/pkg_pkg.cygpart | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/pkg_pkg.cygpart b/lib/pkg_pkg.cygpart
index a7624ff..69e5233 100644
--- a/lib/pkg_pkg.cygpart
+++ b/lib/pkg_pkg.cygpart
@@ -213,7 +213,7 @@ __pkg_pkgcheck() {
local tmp2="${T}/tmpfind.log";
cd ${D};
- __step "Checking packages for missing or duplicate files";
+ __step "Checking packages for unexpected, missing or duplicate files";
rm -f ${tmp1} ${tmp2};
@@ -243,6 +243,13 @@ __pkg_pkgcheck() {
sort < ${tmp1} > "${tmp1}.sorted";
mv -f "${tmp1}.sorted" ${tmp1};
+ if grep "\.stackdump$" ${tmp1} > ${T}/pkgcheck.lst
+ then
+ warning "Packages contain unexpected files:";
+ cat ${T}/pkgcheck.lst;
+ error "Packages contain unexpected files:";
+ fi
+
find * -type f -o -type l | sort > ${tmp2}
if ! diff -U 0 ${tmp2} ${tmp1} > /dev/null
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH cygport] Raise an error if we package a .stackdump file
2018-07-13 16:16 [PATCH cygport] Raise an error if we package a .stackdump file Jon Turney
@ 2020-03-24 3:07 ` Yaakov Selkowitz
0 siblings, 0 replies; 2+ messages in thread
From: Yaakov Selkowitz @ 2020-03-24 3:07 UTC (permalink / raw)
To: cygwin-apps
On Fri, 2018-07-13 at 17:15 +0100, Jon Turney wrote:
> If we end up with a .stackdump file in a package, this tends to suggest
> something has gone wrong somewhere, so raise an error.
> ---
> lib/pkg_pkg.cygpart | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Pushed to master, please test.
--
Yaakov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-24 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 16:16 [PATCH cygport] Raise an error if we package a .stackdump file Jon Turney
2020-03-24 3:07 ` Yaakov Selkowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).