From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH setup 00/13] ListView Package Chooser
Date: Sun, 05 Aug 2018 22:09:00 -0000 [thread overview]
Message-ID: <20180805220851.270212-1-jon.turney@dronecode.org.uk> (raw)
Drag setup into the 1990s, by replacing the custom-drawn package chooser
with a ListView common control.
As well as removing a lot of Win32 GDI drawing, this also enables the
following improvements to be much more straightforward:
* Use standard UI elements to choose an action to take on a package or
category, rather than the weird UX of clicking to cycle around a list of
options of undisclosed length.
* Add tooltips (initially, the ldesc as a tooltip for sdesc)
* Make the package chooser keyboard accessible (not done yet)
The branch for this patch series can be found at:
https://github.com/jon-turney/cygwin-setup/tree/listview
Jon Turney (13):
Change packagemeta::_actions to an enum
Add OnNotify virtual function to class Window for WM_NOTIFY
notifications
Drop 'using namespace std;' from PickView.cc
Use a ListView common control rather than a hand-built grid
Custom draw checkboxes in ListView control
Add methods for listing possible actions on, and applying one to, a
package
Custom draw popup menus in ListView control
Show the count of packages in a category
Use an icon to represent expanded/collapsed state
Use indents in category view
Add LDesc() accessor method to SolvableVersion
Restore packagemeta::LDesc()
Add ldesc tooltips to sdesc column of listview
ActionList.h | 55 +++
ListView.cc | 585 +++++++++++++++++++++++++++++
ListView.h | 96 +++++
Makefile.am | 12 +-
PickCategoryLine.cc | 165 +++-----
PickCategoryLine.h | 81 ++--
PickLine.h | 47 ---
PickPackageLine.cc | 150 ++++----
PickPackageLine.h | 31 +-
PickView.cc | 898 ++++++++------------------------------------
PickView.h | 217 ++++++-----
check-na.bmp | Bin 106 -> 0 bytes
check-no.bmp | Bin 106 -> 0 bytes
check-yes.bmp | Bin 106 -> 0 bytes
choose-spin.bmp | Bin 106 -> 0 bytes
choose.cc | 71 ++--
choose.h | 6 +-
libsolv.cc | 14 +
libsolv.h | 1 +
main.cc | 2 +-
package_meta.cc | 155 ++++----
package_meta.h | 38 +-
proppage.cc | 14 +-
res.rc | 19 +-
resource.h | 13 +-
tree-minus.bmp | Bin 106 -> 0 bytes
tree-minus.ico | Bin 0 -> 299654 bytes
tree-minus.svg | 118 ++++++
tree-plus.bmp | Bin 106 -> 0 bytes
tree-plus.ico | Bin 0 -> 299671 bytes
tree-plus.svg | 126 +++++++
window.h | 7 +
32 files changed, 1608 insertions(+), 1313 deletions(-)
create mode 100644 ActionList.h
create mode 100644 ListView.cc
create mode 100644 ListView.h
delete mode 100644 PickLine.h
delete mode 100644 check-na.bmp
delete mode 100644 check-no.bmp
delete mode 100644 check-yes.bmp
delete mode 100644 choose-spin.bmp
delete mode 100644 tree-minus.bmp
create mode 100644 tree-minus.ico
create mode 100755 tree-minus.svg
delete mode 100644 tree-plus.bmp
create mode 100644 tree-plus.ico
create mode 100644 tree-plus.svg
--
2.17.0
next reply other threads:[~2018-08-05 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 22:09 Jon Turney [this message]
2018-08-05 22:09 ` [PATCH setup 02/13] Add OnNotify virtual function to class Window for WM_NOTIFY notifications Jon Turney
2018-08-05 22:09 ` [PATCH setup 01/13] Change packagemeta::_actions to an enum Jon Turney
2018-08-05 22:09 ` [PATCH setup 03/13] Drop 'using namespace std;' from PickView.cc Jon Turney
2018-08-05 22:10 ` [PATCH setup 06/13] Add methods for listing possible actions on, and applying one to, a package Jon Turney
2018-08-05 22:10 ` [PATCH setup 07/13] Custom draw popup menus in ListView control Jon Turney
2018-08-05 22:10 ` [PATCH setup 05/13] Custom draw checkboxes " Jon Turney
2018-08-05 22:10 ` [PATCH setup 04/13] Use a ListView common control rather than a hand-built grid Jon Turney
2018-08-05 22:10 ` [PATCH setup 09/13] Use an icon to represent expanded/collapsed state Jon Turney
2018-08-05 22:10 ` [PATCH setup 08/13] Show the count of packages in a category Jon Turney
2018-08-05 22:11 ` [PATCH setup 10/13] Use indents in category view Jon Turney
2018-08-05 22:12 ` [PATCH setup 12/13] Restore packagemeta::LDesc() Jon Turney
2018-08-05 22:12 ` [PATCH setup 11/13] Add LDesc() accessor method to SolvableVersion Jon Turney
2018-08-05 22:12 ` [PATCH setup 13/13] Add ldesc tooltips to sdesc column of listview Jon Turney
2018-08-06 14:15 ` [PATCH setup 00/13] ListView Package Chooser Ken Brown
2018-08-06 16:41 ` Achim Gratz
2018-08-06 16:47 ` Achim Gratz
2018-08-06 19:19 ` Ken Brown
2018-10-13 18:46 ` Jon Turney
2018-08-06 16:40 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805220851.270212-1-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).