From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH setup 03/13] Drop 'using namespace std;' from PickView.cc
Date: Sun, 05 Aug 2018 22:09:00 -0000 [thread overview]
Message-ID: <20180805220851.270212-4-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20180805220851.270212-1-jon.turney@dronecode.org.uk>
---
PickView.cc | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/PickView.cc b/PickView.cc
index c583eea..57e8f85 100644
--- a/PickView.cc
+++ b/PickView.cc
@@ -28,8 +28,6 @@
#include "LogSingleton.h"
#include "Exception.h"
-using namespace std;
-
static PickView::Header pkg_headers[] = {
{"Current", 0, 0, true},
{"New", 0, 0, true},
@@ -248,10 +246,10 @@ PickView::mode_caption (views mode)
/* meant to be called on packagemeta::categories */
bool
-isObsolete (set <std::string, casecompare_lt_op> &categories)
+isObsolete (std::set <std::string, casecompare_lt_op> &categories)
{
- set <std::string, casecompare_lt_op>::const_iterator i;
-
+ std::set <std::string, casecompare_lt_op>::const_iterator i;
+
for (i = categories.begin (); i != categories.end (); ++i)
if (isObsolete (*i))
return true;
@@ -295,7 +293,7 @@ PickView::insert_category (Category *cat, bool collapsed)
return;
PickCategoryLine & catline = *new PickCategoryLine (*this, *cat, 1, collapsed);
int packageCount = 0;
- for (vector <packagemeta *>::iterator i = cat->second.begin ();
+ for (std::vector <packagemeta *>::iterator i = cat->second.begin ();
i != cat->second.end () ; ++i)
{
if (packageFilterString.empty () \
@@ -439,7 +437,7 @@ PickView::init_headers (HDC dc)
if (pkg.installed)
note_width (headers, dc, pkg.installed.Canonical_version (),
HMARGIN, current_col);
- for (set<packageversion>::iterator i = pkg.versions.begin ();
+ for (std::set<packageversion>::iterator i = pkg.versions.begin ();
i != pkg.versions.end (); ++i)
{
if (*i != pkg.installed)
--
2.17.0
next prev parent reply other threads:[~2018-08-05 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 22:09 [PATCH setup 00/13] ListView Package Chooser Jon Turney
2018-08-05 22:09 ` [PATCH setup 02/13] Add OnNotify virtual function to class Window for WM_NOTIFY notifications Jon Turney
2018-08-05 22:09 ` Jon Turney [this message]
2018-08-05 22:09 ` [PATCH setup 01/13] Change packagemeta::_actions to an enum Jon Turney
2018-08-05 22:10 ` [PATCH setup 06/13] Add methods for listing possible actions on, and applying one to, a package Jon Turney
2018-08-05 22:10 ` [PATCH setup 04/13] Use a ListView common control rather than a hand-built grid Jon Turney
2018-08-05 22:10 ` [PATCH setup 05/13] Custom draw checkboxes in ListView control Jon Turney
2018-08-05 22:10 ` [PATCH setup 07/13] Custom draw popup menus " Jon Turney
2018-08-05 22:10 ` [PATCH setup 09/13] Use an icon to represent expanded/collapsed state Jon Turney
2018-08-05 22:10 ` [PATCH setup 08/13] Show the count of packages in a category Jon Turney
2018-08-05 22:11 ` [PATCH setup 10/13] Use indents in category view Jon Turney
2018-08-05 22:12 ` [PATCH setup 11/13] Add LDesc() accessor method to SolvableVersion Jon Turney
2018-08-05 22:12 ` [PATCH setup 12/13] Restore packagemeta::LDesc() Jon Turney
2018-08-05 22:12 ` [PATCH setup 13/13] Add ldesc tooltips to sdesc column of listview Jon Turney
2018-08-06 14:15 ` [PATCH setup 00/13] ListView Package Chooser Ken Brown
2018-08-06 16:41 ` Achim Gratz
2018-08-06 16:47 ` Achim Gratz
2018-08-06 19:19 ` Ken Brown
2018-10-13 18:46 ` Jon Turney
2018-08-06 16:40 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805220851.270212-4-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).