public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Lemures Lemniscati <lemures.lemniscati@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
Date: Fri, 07 Aug 2020 23:43:13 +0900	[thread overview]
Message-ID: <20200807234311.4B81.50F79699@gmail.com> (raw)
In-Reply-To: <13b4c88c-8c66-e01b-c321-6f2081e26ad3@dronecode.org.uk>

On Thu, 6 Aug 2020 18:13:52 +0100, Jon Turney
> On 05/08/2020 22:50, Lemures Lemniscati via Cygwin-apps wrote:
> > On Wed, 5 Aug 2020 20:34:24 +0100, Jon Turney
> >>
> >> However, I think there is a consistency problem here, as other variables which should only produce a single line in the .hint file (e.g. REQUIRES, etc.) don't get whitespace canonicalized (as least, that's how it seemed to me when I briefly looked at this).
> >>
> >> Thanks for the patch.
> >
> > Thank you for reviewing.
> >
> > It would be easy to canonicalize through a functiion like
> > __single_line_list () in the commit
> > https://github.com/cygwin-lem/cygport/commit/7607782d3d1972aef6b88ee32f5211f21abbbcfb
> >
> > I'll check later for 'category:', 'requires:', 'obsoletes:',
> > 'provides:', and 'conflicts:'.
> >
> > Any other field to be checked for canonicalization?
> 
> Although it's not very clearly specified in [1], the only keys in a ..hint file for which multiline values are currently permitted are ldesc: and message:
> 
> [1] https://cygwin.com/packaging-hint-files.html

Thank you!


Here is a revised commit:

https://github.com/cygwin-lem/cygport/commit/7bd6b12ee10892b7ec18df93a51dbc274b3af968

Canonicalization of single-line fields in .hint files

We mean trimming and squeezing white spaces by 'canonicalization', here.

- Canonicalization of single-line lists:
  - category
  - requires
  - obsoletes
  - provides
  - conflicts
  - build-depends
- Canonicalization of single-line double-quoted strings:
  - sdesc
  - message


Regards, 

Lem


      reply	other threads:[~2020-08-07 14:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200803205512.E3F1.50F79699@gmail.com>
     [not found] ` <87d047r0ro.fsf@Rainer.invalid>
2020-08-04 12:54   ` Lemures Lemniscati
2020-08-04 13:46     ` Thomas Wolff
2020-08-04 20:34       ` Lemures Lemniscati
2020-08-05 18:31         ` ASSI
2020-08-05 21:21           ` Lemures Lemniscati
2020-08-06 18:25             ` ASSI
2020-08-07  7:45         ` Thomas Wolff
2020-08-07 14:33           ` Lemures Lemniscati
2020-08-07 19:09             ` ASSI
2020-08-08  0:43               ` Lemures Lemniscati
2020-08-08  4:32                 ` ASSI
2020-08-08 11:14                   ` Lemures Lemniscati
2020-08-10  3:42                     ` Lemures Lemniscati
2020-08-10 19:51                       ` Achim Gratz
2020-08-10 21:45                         ` Lemures Lemniscati
2020-08-04 17:02     ` ASSI
2020-08-04 20:49       ` Lemures Lemniscati
2020-08-05 19:34         ` Jon Turney
2020-08-05 21:50           ` Lemures Lemniscati
2020-08-06 17:13             ` Jon Turney
2020-08-07 14:43               ` Lemures Lemniscati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807234311.4B81.50F79699@gmail.com \
    --to=lemures.lemniscati@gmail.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).