From: Lemures Lemniscati <lemures.lemniscati@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cygport: Request a new feature in order to set owner/group names in packaged tarballs.
Date: Tue, 11 Aug 2020 06:45:53 +0900 [thread overview]
Message-ID: <20200811064550.F4BD.50F79699@gmail.com> (raw)
In-Reply-To: <87a6z246uw.fsf@Rainer.invalid>
On Mon, 10 Aug 2020 21:51:35 +0200, Achim Gratz
> Lemures Lemniscati via Cygwin-apps writes:
> > [1]: https://github.com/cygwin-lem/cygport/commit/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b
>
> You set the variable CYGPORT_TAR_EXT in pkg_pkg.cygpart, then use it in
> pkg_upload-cygport. Have you verified tha the latter will have that
> definition included regardless of the code path taken?
>
Thank you for reviewing, Achim.
Both of pkg_pkg.cygpart and pkg_upload.cygpart are called from cygport
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L325-L331
before the functions are called.
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L561-L565
But, probably, configuration like this should go to a more suitable
place, as written in comments (in order to avoid concerning which you
have pointed out)
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/lib/pkg_pkg.cygpart#L23-L24
For example, it might be placed in this part
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L249-L274
Regards,
Lem
next prev parent reply other threads:[~2020-08-10 21:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200803205512.E3F1.50F79699@gmail.com>
[not found] ` <87d047r0ro.fsf@Rainer.invalid>
2020-08-04 12:54 ` Lemures Lemniscati
2020-08-04 13:46 ` Thomas Wolff
2020-08-04 20:34 ` Lemures Lemniscati
2020-08-05 18:31 ` ASSI
2020-08-05 21:21 ` Lemures Lemniscati
2020-08-06 18:25 ` ASSI
2020-08-07 7:45 ` Thomas Wolff
2020-08-07 14:33 ` Lemures Lemniscati
2020-08-07 19:09 ` ASSI
2020-08-08 0:43 ` Lemures Lemniscati
2020-08-08 4:32 ` ASSI
2020-08-08 11:14 ` Lemures Lemniscati
2020-08-10 3:42 ` Lemures Lemniscati
2020-08-10 19:51 ` Achim Gratz
2020-08-10 21:45 ` Lemures Lemniscati [this message]
2020-08-04 17:02 ` ASSI
2020-08-04 20:49 ` Lemures Lemniscati
2020-08-05 19:34 ` Jon Turney
2020-08-05 21:50 ` Lemures Lemniscati
2020-08-06 17:13 ` Jon Turney
2020-08-07 14:43 ` Lemures Lemniscati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811064550.F4BD.50F79699@gmail.com \
--to=lemures.lemniscati@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).