From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH cygport 2/2] Don't use llvm-objdump
Date: Tue, 1 Feb 2022 17:25:19 +0000 [thread overview]
Message-ID: <20220201172519.14881-3-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20220201172519.14881-1-jon.turney@dronecode.org.uk>
This partially reverts commit e06359bca705624b9712fd16f4ec9945935fd608
This partially reverts commit 6f788165848084d2fb1597689b31faba7d4c483e
The polynomially bad runtime of 'objdump' (which made 'llvm-objdump' the
only practically usable tool on larger binaries) has been fixed since
[1]. Meanwhile, 'llvm-objdump' now appears to have bugs which interfere
with the correct operation of cygport.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=18025#c16
---
lib/pkg_info.cygpart | 8 --------
lib/src_postinst.cygpart | 7 +------
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/pkg_info.cygpart b/lib/pkg_info.cygpart
index 4b18993..08ddd69 100644
--- a/lib/pkg_info.cygpart
+++ b/lib/pkg_info.cygpart
@@ -95,14 +95,6 @@ __list_deps() {
dlltool="${CTARGET}-dlltool"
fi
- case ${CHOST} in
- i?86-*|x86_64-*)
- if check_prog llvm-objdump
- then
- objdump="llvm-objdump"
- fi ;;
- esac
-
pushd ${D}
#****v* Information/DEPS_PATH
diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart
index e29b2cb..4b51325 100644
--- a/lib/src_postinst.cygpart
+++ b/lib/src_postinst.cygpart
@@ -951,12 +951,7 @@ __prepstrip() {
continue
fi
- if check_prog llvm-objdump && llvm-size "${exe}" &>/dev/null
- then
- objdump="llvm-objdump"
- else
- objdump=${objcopy/copy/dump}
- fi
+ objdump=${objcopy/copy/dump}
# Static libraries should not be fully stripped, but we can
# still provide split debuginfo if desired
--
2.34.1
prev parent reply other threads:[~2022-02-01 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 17:25 [PATCH cygport 0/2] Avoid misbehaviour with llvm-objdump Jon Turney
2022-02-01 17:25 ` [PATCH cygport 1/2] postinst: Never remove an existing .gnu_debuglink Jon Turney
2022-02-01 19:22 ` Corinna Vinschen
[not found] ` <eef4ada5-0ace-d828-c163-988390aa35e0@dronecode.org.uk>
2022-02-02 9:31 ` Corinna Vinschen
2022-02-01 17:25 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201172519.14881-3-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).