[PATCH] cygutils/cygdrop: fix return type of usageCore

[PATCH] cygutils/cygdrop: fix return type of usageCore

[Jeremy Drake]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

Fixes a warning "no return statement in function returning non-void",
and solves a crash running --help.

Hopefully this is the right place for this now, since I am not interesting
in becoming a package maintainer as the list description says ;)

[-- Attachment #2: Type: text/plain, Size: 833 bytes --]

From f4821db24d4e4feca16e4aea58843128e233ef4e Mon Sep 17 00:00:00 2001
From: Jeremy Drake <cygwin@jdrake.com>
Date: Tue, 25 May 2021 16:13:17 -0700
Subject: [PATCH] cygdrop: fix return type of usageCore

Fixes a warning "no return statement in function returning non-void",
and solves a crash running --help.
---
 src/cygdrop/cygdrop.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cygdrop/cygdrop.cc b/src/cygdrop/cygdrop.cc
index 35bcc19..dc403c9 100644
--- a/src/cygdrop/cygdrop.cc
+++ b/src/cygdrop/cygdrop.cc
@@ -39,7 +39,7 @@ static void help (FILE * f, const char *name);
 static void version (FILE * f, const char *name);
 static void license (FILE * f, const char *name);
 
-static int
+static void
 usageCore (FILE * f, const char * name)
 {
   fprintf (f,
-- 
2.31.1

Re: [PATCH] cygutils/cygdrop: fix return type of usageCore

[Mark Geisert]

Hi Jeremy,

Jeremy Drake via Cygwin-apps wrote:
> Fixes a warning "no return statement in function returning non-void",
> and solves a crash running --help.
> 
> Hopefully this is the right place for this now, since I am not interesting
> in becoming a package maintainer as the list description says ;)

Thanks for the report and patch.  I can't reproduce the crash but no worries.  The 
patch will be part of the next update to cygutils in a short while.

..mark