public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH setup] Fix Chinese Help Message fall in dead loop .
Date: Thu, 28 Mar 2024 21:48:24 -0600	[thread overview]
Message-ID: <3486a2c4-ddd0-46f7-aaa5-1fec67e2f76b@SystematicSW.ab.ca> (raw)
In-Reply-To: <tencent_248972F194FB6C491C101A513392A31FAD0A@qq.com>

On 2024-03-28 19:40, 赵伟 via Cygwin-apps wrote:
> ---
>   libgetopt++/include/getopt++/DefaultFormatter.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libgetopt++/include/getopt++/DefaultFormatter.h b/libgetopt++/include/getopt++/DefaultFormatter.h
> index ee2397f5..43c253a5 100644
> --- a/libgetopt++/include/getopt++/DefaultFormatter.h
> +++ b/libgetopt++/include/getopt++/DefaultFormatter.h
> @@ -64,6 +64,7 @@ class DefaultFormatter {
>          {
>            // TODO: consider using a line breaking strategy here.
>            int pos = helpmsg.substr(0,h_len).find_last_of(" ");
> +         if(!pos)break; /*In Chinese Helpmsg,may has no space,so pos ==0,and code will fall in dead loop here*/
>            theStream << helpmsg.substr(0,pos)
>                      << std::endl << std::string (o_len, ' ');
>            helpmsg.erase (0,pos+1);

It seems that the best approach for Chinese translations would be to:

- add spaces at sentence or word breaks in translations before 35 or 45 bytes, 
if that is the length unit, worth of characters are output in each column; or

- add a language dependent line breaking strategy, to honour characters not to 
be placed at the beginning or ends of lines or split; or

- split between characters, as with long strings in other languages.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry


  reply	other threads:[~2024-03-29  3:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  1:40 =?gb18030?B?1dTOsA==?=
2024-03-29  3:48 ` Brian Inglis [this message]
2024-03-29 16:32 ` Jon Turney
  -- strict thread matches above, loose matches on Subject: below --
2024-03-29  1:35 =?gb18030?B?1dTOsA==?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3486a2c4-ddd0-46f7-aaa5-1fec67e2f76b@SystematicSW.ab.ca \
    --to=brian.inglis@systematicsw.ab.ca \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).