[PATCH setup] Fix Chinese Help Message fall in dead loop .

[PATCH setup] Fix Chinese Help Message fall in dead loop .

[=?gb18030?B?1dTOsA==?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 806 bytes --]

---
 libgetopt++/include/getopt++/DefaultFormatter.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libgetopt++/include/getopt++/DefaultFormatter.h b/libgetopt++/include/getopt++/DefaultFormatter.h
index ee2397f5..43c253a5 100644
--- a/libgetopt++/include/getopt++/DefaultFormatter.h
+++ b/libgetopt++/include/getopt++/DefaultFormatter.h
@@ -64,6 +64,7 @@ class DefaultFormatter {
        {
          // TODO: consider using a line breaking strategy here.
          int pos = helpmsg.substr(0,h_len).find_last_of(" ");
+         if(!pos)break; /*In Chinese Helpmsg,may has no space,so pos ==0,and code will fall in dead loop here*/
          theStream << helpmsg.substr(0,pos)
                    << std::endl << std::string (o_len, ' ');
          helpmsg.erase (0,pos+1);
--
2.43.0

Re: [PATCH setup] Fix Chinese Help Message fall in dead loop .

[Brian Inglis]

On 2024-03-28 19:40, 赵伟 via Cygwin-apps wrote:
> ---
>   libgetopt++/include/getopt++/DefaultFormatter.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libgetopt++/include/getopt++/DefaultFormatter.h b/libgetopt++/include/getopt++/DefaultFormatter.h
> index ee2397f5..43c253a5 100644
> --- a/libgetopt++/include/getopt++/DefaultFormatter.h
> +++ b/libgetopt++/include/getopt++/DefaultFormatter.h
> @@ -64,6 +64,7 @@ class DefaultFormatter {
>          {
>            // TODO: consider using a line breaking strategy here.
>            int pos = helpmsg.substr(0,h_len).find_last_of(" ");
> +         if(!pos)break; /*In Chinese Helpmsg,may has no space,so pos ==0,and code will fall in dead loop here*/
>            theStream << helpmsg.substr(0,pos)
>                      << std::endl << std::string (o_len, ' ');
>            helpmsg.erase (0,pos+1);

It seems that the best approach for Chinese translations would be to:

- add spaces at sentence or word breaks in translations before 35 or 45 bytes, 
if that is the length unit, worth of characters are output in each column; or

- add a language dependent line breaking strategy, to honour characters not to 
be placed at the beginning or ends of lines or split; or

- split between characters, as with long strings in other languages.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

Re: [PATCH setup] Fix Chinese Help Message fall in dead loop .

[Jon Turney]

On 29/03/2024 01:40, 赵伟 via Cygwin-apps wrote:
> ---
>   libgetopt++/include/getopt++/DefaultFormatter.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libgetopt++/include/getopt++/DefaultFormatter.h b/libgetopt++/include/getopt++/DefaultFormatter.h
> index ee2397f5..43c253a5 100644
> --- a/libgetopt++/include/getopt++/DefaultFormatter.h
> +++ b/libgetopt++/include/getopt++/DefaultFormatter.h
> @@ -64,6 +64,7 @@ class DefaultFormatter {
>          {
>            // TODO: consider using a line breaking strategy here.
>            int pos = helpmsg.substr(0,h_len).find_last_of(" ");
> +         if(!pos)break; /*In Chinese Helpmsg,may has no space,so pos ==0,and code will fall in dead loop here*/
>            theStream << helpmsg.substr(0,pos)
>                      << std::endl << std::string (o_len, ' ');
>            helpmsg.erase (0,pos+1);
> --
> 2.43.0

Thanks very much for bug report, and the patch!

Did you actually try this?  When I tested this it didn't help, as 
std::string::substr() returns std::string::npos (numerically, -1), not 0 
when it cannot find a match.

So, I applied a slightly modified version of the patch.

Please try https://cygwin.com/setup/setup-2.931-1-g0ee13c.x86_64.exe

[PATCH setup] Fix Chinese Help Message fall in dead loop .

[=?gb18030?B?1dTOsA==?=]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1166 bytes --]

---
 libgetopt++/include/getopt++/DefaultFormatter.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libgetopt++/include/getopt++/DefaultFormatter.h b/libgetopt++/include/getopt++/DefaultFormatter.h
index ee2397f5..43c253a5 100644
--- a/libgetopt++/include/getopt++/DefaultFormatter.h
+++ b/libgetopt++/include/getopt++/DefaultFormatter.h
@@ -64,6 +64,7 @@ class DefaultFormatter {
        {
          // TODO: consider using a line breaking strategy here.
          int pos = helpmsg.substr(0,h_len).find_last_of(" ");
+         if(!pos)break; /*In Chinese Helpmsg,may has no space,so pos ==0,and code will fall in dead loop here*/
          theStream << helpmsg.substr(0,pos)
                    << std::endl << std::string (o_len, ' ');
          helpmsg.erase (0,pos+1);
--
2.43.0