From: Jon Turney <jon.turney@dronecode.org.uk>
To: Chad Dougherty <crd@acm.org>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITA] lz4
Date: Sun, 30 Oct 2022 14:26:30 +0000 [thread overview]
Message-ID: <34c70f4f-fa6a-8504-b9ef-158d97940ce8@dronecode.org.uk> (raw)
In-Reply-To: <5efaf04b-5030-0ea2-2763-8bd0bb773255@acm.org>
On 24/10/2022 01:39, Chad Dougherty wrote:
> On 2022-10-23 13:31, Adam Dinwoodie wrote:
>> On Sat, 22 Oct 2022 at 21:59, Chad Dougherty wrote:
>>> I'd like to adopt the lz4 library that is currently listed as orphaned.
>>>
>>> I've updated the cygport to the current version, 1.9.4:
>>> https://github.com/crd477/lz4-cygport
>>
>> I've not tested the actual compilation, but I have done some test
>> builds, and this all looks good to me!
>>
>
> Great!
Looks like 'doc/lz4_manual.html' is created in the source directory by
the build.
That should be listed in DIFF_EXCLUDES, and maybe installed to be
included in the devel package?
>>> Also, is it expected that I should also take the
>>> mingw64-{i686,x86_64}-lz4 packages too?
>>
>> AIUI that's preferred but not required; they're separate packages, so
>> it's entirely possible for them to have separate maintainers.
>
> OK, I updated them here:
> https://github.com/crd477/mingw64-x86_64-lz4-cygport
> https://github.com/crd477/mingw64-i686-lz4-cygport
>
> I've had less experience with cross-compiling but I think they're
> correct nevertheless.
You should 'git rm' the patches which are no longer used.
I added these to your authorized packages.
Thanks!
next prev parent reply other threads:[~2022-10-30 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 20:59 Chad Dougherty
2022-10-23 17:31 ` Adam Dinwoodie
2022-10-24 0:39 ` Chad Dougherty
2022-10-30 14:26 ` Jon Turney [this message]
2022-10-30 16:55 ` Chad Dougherty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c70f4f-fa6a-8504-b9ef-158d97940ce8@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=crd@acm.org \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).