public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: Re: gnulib m4/threadlib.m4 bug crashing package tests
Date: Sun, 28 Nov 2021 13:21:53 -0500	[thread overview]
Message-ID: <355a27be-3de5-8c71-79f5-e1188d9021dd@cornell.edu> (raw)
In-Reply-To: <87ilwc44uy.fsf@Rainer.invalid>

On 11/28/2021 11:33 AM, Achim Gratz wrote:
> Ken Brown via Cygwin-apps writes:
>> It's gnulib that changed, not Cygwin or gcc/binutils.  This is
>> actually an old issue:
>>
>>    https://cygwin.com/pipermail/cygwin/2010-April/186342.html
> 
> I've built the exact same package (man-db) this Febrary without that
> problem and now again with that problem (it doesn't help that the test
> suite never actually runs the failing executable).  The gnulib test
> failed (as it still does on 32bit) for 64bit in February, but succeeds
> (resulting in gnulib trying to use weak symbols) now.

You're right, I was wrong.  Here's the gnulib test program for anyone else who 
wants to look at this:

#include <stdio.h>
#pragma weak fputs
int main ()
{
   return (fputs == NULL);
}

As you said, this used to return 1, but now it returns 0 on 64-bit.  Running 
under gdb I see

(gdb) p fputs
$1 = {int (const char * restrict, FILE * restrict)} 0x1801b0540 <fputs>

This is a change, and it's actually what one would expect.  But, as Dave Korn 
explained in

   https://cygwin.com/pipermail/cygwin/2010-April/186350.html ,

it doesn't mean that weak symbols on Cygwin behave the way they do on ELF 
platforms.  So I agree with you that this is a bogus test.

Ken

  reply	other threads:[~2021-11-28 18:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 23:46 Brian Inglis
2021-11-25 16:26 ` Ken Brown
2021-11-25 18:25   ` Yaakov Selkowitz
2021-11-26  4:48     ` Brian Inglis
2021-11-26 13:08     ` Ken Brown
2021-11-26 17:34       ` Brian Inglis
2021-11-26 18:17         ` Ken Brown
2021-11-28 15:42     ` Achim Gratz
2021-11-28 15:56       ` Ken Brown
2021-11-28 16:33         ` Achim Gratz
2021-11-28 18:21           ` Ken Brown [this message]
2021-11-29 16:39             ` Achim Gratz
2021-12-08 18:49               ` Achim Gratz
2021-12-09  4:41                 ` Brian Inglis
2021-11-28 16:23       ` Achim Gratz
2021-11-28 18:34         ` Brian Inglis
2021-11-29 17:38           ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=355a27be-3de5-8c71-79f5-e1188d9021dd@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).