Re: gnulib m4/threadlib.m4 bug crashing package tests

[Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>]

On 2021-11-26 06:08, Ken Brown via Cygwin-apps wrote:
> On 11/25/2021 1:25 PM, Yaakov Selkowitz via Cygwin-apps wrote:
>> Add gl_cv_have_weak=no to cygconf?
> 
> Are you suggesting maintainers should do this, or are you talking about 
> patching cygport, like this:
> 
> diff --git a/cygclass/autotools.cygclass b/cygclass/autotools.cygclass
> index 712f437..8b6fdde 100644
> --- a/cygclass/autotools.cygclass
> +++ b/cygclass/autotools.cygclass
> @@ -735,6 +735,14 @@ cygconf() {
>                  export ac_cv_func_mmap_fixed_mapped=yes ;;
>          esac
> 
> +       # Some versions of gnulib's threadlib.m4:gl_WEAK_SYMBOLS
> +       # incorrectly report that Cygwin supports weak symbols.  See
> +       # 
> https://cygwin.com/pipermail/cygwin-apps/2021-September/041587.html.
> +       case ${CHOST} in
> +       *-*-cygwin*)
> +               export gl_cv_have_weak=no ;;
> +       esac
> +
>          # packages that use intltool w/o glib-gettext get this wrong
>          export DATADIRNAME="share"

Normally in a regular/autotools build the maintainer appends these 
overrides to:

	CYGCONF_ARGS=...gl_cv_have_weak=guessing\ no

or to:

src_compile() {
         cd ${S}
         cygautoreconf
         cd ${B}
	cygconf ... gl_cv_have_weak=guessing\ no
         cygmake
}

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]